Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the compatibility issue of import statements on Windows. #168

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

hamflx
Copy link
Contributor

@hamflx hamflx commented Oct 29, 2024

issue

image

the correct path should be 'D:\repos\vapd-extensions\node_modules\rollup-plugin-sass\dist/insertStyle.js'

but I got

epos
apd-extensions
ollup-plugin-sassdist/insertStyle.js

This PR also fixes the error reported by the "Should insert CSS into head tag" unit test on Windows.

before

image

after

image

Copy link
Owner

@elycruz elycruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR @hamflx . Looks good.

@elycruz elycruz merged commit ebb8035 into elycruz:main Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants