Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for three-valued BooleanControl #2906

Closed
ptitzler opened this issue Aug 24, 2022 · 2 comments · Fixed by #2927
Closed

Add support for three-valued BooleanControl #2906

ptitzler opened this issue Aug 24, 2022 · 2 comments · Fixed by #2927
Assignees
Labels

Comments

@ptitzler
Copy link
Member

Is your feature request related to a problem? Please describe.

The BooleanControl widget enables users to specify a boolean property value by checking/unchecking a box. This implementation does not support scenarios where users should be able to choose from three values: true, false, and null, with null representing 'not set'.

Example
Enable users to prevent use of cached node outputs

  • user explicitly declines use of cached node outputs
  • user explicitly accepts use of cached node outputs
  • user defers the decision to the runtime environment (Elyra does not have any insights into how the environment is configured)

Describe the solution you'd like
Perhaps a select box with three options. The label text for each option should be customizable, and the returned values be one of true/false/null.

Describe alternatives you've considered
It might probably be possible to implement a one-off solution using EnumControl but it wouldn't be re-usable.

@kiersten-stokes
Copy link
Member

I think the RJSF stuff will really simplify using an enum for this. I'll play around with some options and report back!

@kiersten-stokes kiersten-stokes self-assigned this Aug 24, 2022
@lresende
Copy link
Member

Having the user see one thing in the front-end and behave differently on the backend can cause confusion, I would suggest we set defaults with the expected backend behavior if nothing was selected.

NOT A CONTRIBUTION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants