From 2241aeb07ff77a3b23fa5af42a5222ecb8336238 Mon Sep 17 00:00:00 2001 From: Hollow Man Date: Fri, 31 Jul 2020 18:08:26 +0800 Subject: [PATCH 1/2] PDF-Viewer: Add restriction to PDF files only #314 Signed-off-by: Hollow Man --- app/pdf-viewer/buffer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/pdf-viewer/buffer.py b/app/pdf-viewer/buffer.py index 6cbb5b988..3d3fe1c0f 100755 --- a/app/pdf-viewer/buffer.py +++ b/app/pdf-viewer/buffer.py @@ -328,7 +328,7 @@ def get_page_pixmap(self, index, scale): self.char_dict[index] = self.get_page_char_rect_list(index) self.select_area_annot_cache_dict[index] = None - if self.emacs_var_dict["eaf-pdf-dark-mode"] == "follow": + if self.emacs_var_dict["eaf-pdf-dark-mode"] == "follow" and self.url.split(".")[-1] == "pdf": col = self.handle_color(QColor(self.emacs_var_dict["eaf-emacs-theme-background-color"]), self.inverted_mode) page.drawRect(page.rect, color=col, fill=col, overlay=False) From 76b950d60371a1b5bf275c8cdcd82a51f2bc95fa Mon Sep 17 00:00:00 2001 From: Hollow Man Date: Fri, 31 Jul 2020 21:34:28 +0800 Subject: [PATCH 2/2] Use Python built in method Signed-off-by: Hollow Man --- app/pdf-viewer/buffer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/pdf-viewer/buffer.py b/app/pdf-viewer/buffer.py index 3d3fe1c0f..839deddd6 100755 --- a/app/pdf-viewer/buffer.py +++ b/app/pdf-viewer/buffer.py @@ -328,7 +328,7 @@ def get_page_pixmap(self, index, scale): self.char_dict[index] = self.get_page_char_rect_list(index) self.select_area_annot_cache_dict[index] = None - if self.emacs_var_dict["eaf-pdf-dark-mode"] == "follow" and self.url.split(".")[-1] == "pdf": + if self.emacs_var_dict["eaf-pdf-dark-mode"] == "follow" and os.path.splitext(self.url)[-1] == ".pdf": col = self.handle_color(QColor(self.emacs_var_dict["eaf-emacs-theme-background-color"]), self.inverted_mode) page.drawRect(page.rect, color=col, fill=col, overlay=False)