Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move evil-surround to the emacs-evil org #842

Closed
ninrod opened this issue Jun 1, 2017 · 14 comments
Closed

move evil-surround to the emacs-evil org #842

ninrod opened this issue Jun 1, 2017 · 14 comments
Labels

Comments

@ninrod
Copy link
Member

ninrod commented Jun 1, 2017

I have @timcharper blessing to move evil-surround to the evil org.

How should we go about this?

@TheBB
Copy link
Member

TheBB commented Jun 1, 2017

That's awesome. I have invited you to the organization. When you accept, I'll create an empty repository called evil-surround for you and give you write access to it. Then you can push it there, change whatever URLs you need to, and then finally go to MELPA and update its build URL.

@TheBB
Copy link
Member

TheBB commented Jun 1, 2017

Of course I can do the migration too, if that's what @wasamasa wants.

@wasamasa
Copy link
Member

wasamasa commented Jun 1, 2017

It might be better for @TheBB to do the migration so that issues can be transferred. The whole point of @ninrod taking over maintainership was to get the package into better shape, no?

@edkolev
Copy link
Member

edkolev commented Jun 1, 2017

As a regular evil-surround user, I'm willing to contribute to evil-surrond.

However, the lack of tests in that repo is a show-stopper for me. For example, VSb behaves differently in emacs than in vim -- emacs doesn't indent after surrounding, plus inserts a fake line 4-5 spaces below the newly surrounded line. So far I've preferred to cleanup the spaces and indent myself, rather than deal with a zero-tests repo.

@ninrod let me know if you want help with improving the evil-surround package

@ninrod
Copy link
Member Author

ninrod commented Jun 1, 2017

folks, this is great news.

Migrating the issues should be useful. if @TheBB can do that, awesome.

@edkolev, by all means please let us all write some tests for evil-surround! Yes let's all improve the package! maybe even setup travis and coverage analysis. I don't know how to do that, so it should be fun and I'll learn much elisp in the process.

@TheBB
Copy link
Member

TheBB commented Jun 1, 2017

The easiest way to do this is to get @timcharper to transfer ownership of the repo to us. That will bring issues and PRs along with it. I've sent him an invite to the organization so when he accepts, he will be able to go into the admin page for his own repo and transfer ownership. @ninrod I assume you can ping him to do this.

@ninrod
Copy link
Member Author

ninrod commented Jun 1, 2017

@TheBB, yes I can ping him. If I understand correctly, he must transfer the ownership of the repo to the github.com/emacs-evil organization, right?

@TheBB
Copy link
Member

TheBB commented Jun 1, 2017

Yes

@ninrod
Copy link
Member Author

ninrod commented Jun 2, 2017

@TheBB, @timcharper responded my ping just a few minutes ago. He said this:

Found the invite; transfer initiated. Thanks!

@TheBB
Copy link
Member

TheBB commented Jun 2, 2017

Excellent, you both have write access automatically I see. Once you have changed the melpa recipe this can be closed then.

@ninrod
Copy link
Member Author

ninrod commented Jun 2, 2017

awesome! I should be able to work on this soon.

@ninrod
Copy link
Member Author

ninrod commented Jun 4, 2017

just an update: I have submitted pull 4785 to melpa. Just waiting for that to be merged in to close this.

@ninrod
Copy link
Member Author

ninrod commented Jun 5, 2017

Gentleman, seems that we're live. #4785 is merged in melpa.

@wasamasa
Copy link
Member

wasamasa commented Jun 5, 2017

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants