fix(@embark/ganache): make embark blockchain exit when using Ganache

embarklabs · Mar 10, 2020 · 53dc751 · 53dc751
1 parent c624582
commit 53dc751
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/packages/plugins/ganache/src/index.js b/packages/plugins/ganache/src/index.js
@@ -20,7 +20,7 @@ class Ganache {
         this._registerStatusCheck();
         this._getProvider(); // No need to return anything, we just want to populate currentProvider
         this.embark.logger.info(__('Blockchain node is ready').cyan);
-        cb();
+        cb(null, true);
       },
       stopFn: (cb) => {
         this.currentProvider = null;

diff --git a/packages/stack/blockchain/src/index.js b/packages/stack/blockchain/src/index.js
@@ -78,9 +78,9 @@ export default class Blockchain {
           return cb(null, true);
         }
         // start node
-        client.launchFn.call(client, () => {
+        client.launchFn.call(client, (_err, isVM) => {
           started();
-          cb();
+          cb(null, isVM);
         });
       });
     });

diff --git a/packages/stack/proxy/src/index.ts b/packages/stack/proxy/src/index.ts
@@ -130,7 +130,6 @@ export default class ProxyManager {
 
     // HTTP
     this.httpProxy = await new Proxy({
-      endpoint,
       events: this.events,
       isWs: false,
       logger: this.logger,