From b0e71d94278c475328a028cc4f2a8daa914d3c48 Mon Sep 17 00:00:00 2001 From: Pascal Precht Date: Tue, 5 Nov 2019 16:22:11 +0100 Subject: [PATCH] fix(@embark/console): ensure Cockpit is only started in non-secondary mode (#2026) `embark console` registers and tries to spin up `Cockpit`, even when there's already a Cockpit instance running and thefore exits with an error that a certain port is already in use. This commit ensures that Cockpit is only bootstrapped when `embark console` is executed as a non-secondary process, meaning that there's no other `embark run` process active that might occupy Cockpit's default port. --- packages/embark/src/cmd/cmd_controller.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/embark/src/cmd/cmd_controller.js b/packages/embark/src/cmd/cmd_controller.js index 6e8cd9f01e..d4c1e7f049 100644 --- a/packages/embark/src/cmd/cmd_controller.js +++ b/packages/embark/src/cmd/cmd_controller.js @@ -380,7 +380,9 @@ class EmbarkController { engine.registerModuleGroup("webserver"); engine.registerModuleGroup("filewatcher"); engine.registerModuleGroup("storage"); - engine.registerModuleGroup("cockpit"); + if (!isSecondaryProcess(engine)) { + engine.registerModuleGroup("cockpit"); + } engine.registerModulePackage('embark-deploy-tracker', {plugins: engine.plugins}); callback();