-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support large file uploads to IPFS #774
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 180.0 DAI (180.0 USD @ $1.0/DAI) attached to it.
|
Hello embark! this is my first contribution to this repository. |
Seems like we need to wait for ipfs-inactive/js-ipfs-http-client#851 |
@iurimatias Do you agree that we have a blocker here? Thanks for digging around, @kziemianek! |
@kziemianek Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@kziemianek @vs77bb IMO fixing it it in js-ipfs-api if necessary can be considered part of the bounty. |
@iurimatias it's getting solved in linked PR. What can be done here is ipfs-api version bump and verification after release of the feature in ipfs-api. If it's ok for You I can keep an eye on it. |
@iurimatias seems like ipfs-api version bump will be required to get this working, embark is currently at 17.x.x while ipfs-api most recent is 24.x. Would it be a problem ? I tried it locally but demo is not working after migration to v24.0.1 so it might not be trivial. Ever considered updating ipfs-api version to most recent ? |
@kziemianek Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@kziemianek Are you waiting on feedback from @iurimatias here to continue? Snoozing Gitcoin Bot for 5 days 👍 |
@vs77bb yes . |
@kziemianek Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
I'm waiting for fix in ipfs-api, please snooze for 100 days because it may take long time. |
Hey @kziemianek you may want to try ipfs-api v25.0.0, it shipped with a fix (ipfs-inactive/js-ipfs-http-client#868) that should make 1GB+ uploads possible. |
So, this should be ready to play the example with that v25.0.0 fix? |
Thank you for bringing this to my attention! In short, when working with bigger files you don't want to create a Buffer from file contents (like here), |
@karankohli13 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@karankohli13 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@kziemianek - Frank from Gitcoin here - still waiting on feedback? |
Suggestion: while waiting for streaming through HTTP is working as expected, why don't just use |
Issue Status: 1. Open 2. Cancelled The funding of 180.0 DAI (180.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter
|
@iurimatias does it make sense to close this one (and revisit later) due to inactivity? |
Outline
Currently attempting to upload a large file to IPFS through EmbarkJS api (see uploading file in documentation) will get the browser stuck. The goal of this task is to fix the code so it can support large file uploads to decentralized systems, namely IPFS.
Acceptance Criteria
EmbarkJS.Storage.uploadFile
as specified in the documentation should not get the browser stuck and the file should be able to be downloaded afterwards.The text was updated successfully, but these errors were encountered: