From 28d56b91642f4c35e822092de945844ba1314246 Mon Sep 17 00:00:00 2001 From: "Michael Bradley, Jr" Date: Thu, 2 May 2019 13:24:38 -0500 Subject: [PATCH] build: use babel cli's `--extensions` consistently in all packages If a package uses only `.js` then supply `--extensions ".js"`. If a package uses only `.ts` then supply `--extensions ".ts"`. If a package uses both, then supply `--extensions ".js,.ts"`. The reason for this is that adding/removing TS/JS support ought to occasion revising a package's `package.json` file and adjusting other scripts as well, e.g. for linting. With these changes, it won't work to simply start adding `.ts` files in a package's `src/` directory, which should prompt the developer to review `package.json` and make the appropriate changes, and/or other developers may realize changes need to be made during code review. --- packages/embark-api-client/package.json | 2 +- packages/embark-api/package.json | 2 +- packages/embark-async-wrapper/package.json | 2 +- packages/embark-authenticator/package.json | 2 +- packages/embark-compiler/package.json | 2 +- packages/embark-contracts-manager/package.json | 2 +- packages/embark-core/package.json | 2 +- packages/embark-ens/package.json | 2 +- packages/embark-graph/package.json | 2 +- packages/embark-library-manager/package.json | 2 +- packages/embark-logger/package.json | 2 +- packages/embark-process-logs-api/package.json | 2 +- packages/embark-profiler/package.json | 2 +- packages/embark-scaffolding/package.json | 2 +- packages/embark-specialconfigs/package.json | 2 +- packages/embark-test-runner/package.json | 2 +- packages/embark-transaction-tracker/package.json | 2 +- packages/embark-vyper/package.json | 2 +- packages/embark-watcher/package.json | 2 +- packages/embark-webserver/package.json | 2 +- packages/embark-whisper/package.json | 2 +- packages/embarkjs-ipfs/package.json | 8 ++++---- packages/embarkjs-swarm/package.json | 8 ++++---- packages/embarkjs-whisper/package.json | 8 ++++---- packages/embarkjs/package.json | 8 ++++---- 25 files changed, 37 insertions(+), 37 deletions(-) diff --git a/packages/embark-api-client/package.json b/packages/embark-api-client/package.json index b079d356a3..5ca1146bc5 100644 --- a/packages/embark-api-client/package.json +++ b/packages/embark-api-client/package.json @@ -26,7 +26,7 @@ "dist" ], "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-api/package.json b/packages/embark-api/package.json index ea0ff2d4ca..c4c1357768 100644 --- a/packages/embark-api/package.json +++ b/packages/embark-api/package.json @@ -26,7 +26,7 @@ "dist" ], "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".ts\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-async-wrapper/package.json b/packages/embark-async-wrapper/package.json index 44f000609c..0a960f853e 100644 --- a/packages/embark-async-wrapper/package.json +++ b/packages/embark-async-wrapper/package.json @@ -26,7 +26,7 @@ "dist" ], "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-authenticator/package.json b/packages/embark-authenticator/package.json index d54a731b19..ef837edf98 100644 --- a/packages/embark-authenticator/package.json +++ b/packages/embark-authenticator/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-compiler/package.json b/packages/embark-compiler/package.json index 0286bb4ab1..19d9687246 100644 --- a/packages/embark-compiler/package.json +++ b/packages/embark-compiler/package.json @@ -26,7 +26,7 @@ "dist" ], "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".ts\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-contracts-manager/package.json b/packages/embark-contracts-manager/package.json index 15912c451a..1c056d2b60 100644 --- a/packages/embark-contracts-manager/package.json +++ b/packages/embark-contracts-manager/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-core/package.json b/packages/embark-core/package.json index 92753af260..32a22a95af 100644 --- a/packages/embark-core/package.json +++ b/packages/embark-core/package.json @@ -27,7 +27,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-ens/package.json b/packages/embark-ens/package.json index 373466f097..b35069e8ef 100644 --- a/packages/embark-ens/package.json +++ b/packages/embark-ens/package.json @@ -27,7 +27,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-graph/package.json b/packages/embark-graph/package.json index 88b4de2f1b..4d988993cf 100644 --- a/packages/embark-graph/package.json +++ b/packages/embark-graph/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-library-manager/package.json b/packages/embark-library-manager/package.json index 1d719b3107..8fb3ab4a57 100644 --- a/packages/embark-library-manager/package.json +++ b/packages/embark-library-manager/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-logger/package.json b/packages/embark-logger/package.json index 93b69a577f..4265c97564 100644 --- a/packages/embark-logger/package.json +++ b/packages/embark-logger/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-process-logs-api/package.json b/packages/embark-process-logs-api/package.json index 070ba417d7..8cc08cd534 100644 --- a/packages/embark-process-logs-api/package.json +++ b/packages/embark-process-logs-api/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-profiler/package.json b/packages/embark-profiler/package.json index 18f3364969..6a85341554 100644 --- a/packages/embark-profiler/package.json +++ b/packages/embark-profiler/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-scaffolding/package.json b/packages/embark-scaffolding/package.json index a34fdb3f05..22204d1e71 100644 --- a/packages/embark-scaffolding/package.json +++ b/packages/embark-scaffolding/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps --copy-files", + "build": "cross-env BABEL_ENV=node babel src --copy-files --extensions \".ts\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "copy:templates": "cp -rf src/**/*.hbs dist/", diff --git a/packages/embark-specialconfigs/package.json b/packages/embark-specialconfigs/package.json index 0ae7e7edf1..513a434987 100644 --- a/packages/embark-specialconfigs/package.json +++ b/packages/embark-specialconfigs/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-test-runner/package.json b/packages/embark-test-runner/package.json index 1a56ef3ba3..e5bd24aaa8 100644 --- a/packages/embark-test-runner/package.json +++ b/packages/embark-test-runner/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-transaction-tracker/package.json b/packages/embark-transaction-tracker/package.json index 9ee346ce74..8992ff69e1 100644 --- a/packages/embark-transaction-tracker/package.json +++ b/packages/embark-transaction-tracker/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-vyper/package.json b/packages/embark-vyper/package.json index 17a56ccf86..eb9c47cdb7 100644 --- a/packages/embark-vyper/package.json +++ b/packages/embark-vyper/package.json @@ -26,7 +26,7 @@ "dist" ], "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-watcher/package.json b/packages/embark-watcher/package.json index 6289f9d496..3e6bc76d31 100644 --- a/packages/embark-watcher/package.json +++ b/packages/embark-watcher/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-webserver/package.json b/packages/embark-webserver/package.json index 67bc102a45..77ae61373f 100644 --- a/packages/embark-webserver/package.json +++ b/packages/embark-webserver/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --copy-files --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --copy-files --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embark-whisper/package.json b/packages/embark-whisper/package.json index 474fc25559..bf96909b90 100644 --- a/packages/embark-whisper/package.json +++ b/packages/embark-whisper/package.json @@ -26,7 +26,7 @@ }, "main": "./dist/index.js", "scripts": { - "build": "cross-env BABEL_ENV=node babel src --extensions \".js,.ts\" --out-dir dist --root-mode upward --source-maps", + "build": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "lint": "npm-run-all lint:*", diff --git a/packages/embarkjs-ipfs/package.json b/packages/embarkjs-ipfs/package.json index 4230b9ca38..04b0a15615 100644 --- a/packages/embarkjs-ipfs/package.json +++ b/packages/embarkjs-ipfs/package.json @@ -35,10 +35,10 @@ ], "scripts": { "build": "npm-run-all build:**", - "build:browser": "cross-env BABEL_ENV=browser babel src --out-dir dist/browser --root-mode upward", - "build:node": "cross-env BABEL_ENV=node babel src --out-dir dist --root-mode upward --source-maps", - "build:node:async": "cross-env BABEL_ENV=node:async babel src/node --out-dir dist --root-mode upward --source-maps", - "// build:node:test": "cross-env BABEL_ENV=node:test babel test --out-dir build-test --root-mode upward --source-maps", + "build:browser": "cross-env BABEL_ENV=browser babel src --extensions \".js\" --out-dir dist/browser --root-mode upward", + "build:node": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", + "build:node:async": "cross-env BABEL_ENV=node:async babel src/node --extensions \".js\" --out-dir dist --root-mode upward --source-maps", + "// build:node:test": "cross-env BABEL_ENV=node:test babel test --extensions \".js\" --out-dir build-test --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "package": "npm pack", diff --git a/packages/embarkjs-swarm/package.json b/packages/embarkjs-swarm/package.json index d0be025cca..02bdd46a40 100644 --- a/packages/embarkjs-swarm/package.json +++ b/packages/embarkjs-swarm/package.json @@ -35,10 +35,10 @@ ], "scripts": { "build": "npm-run-all build:**", - "build:browser": "cross-env BABEL_ENV=browser babel src --out-dir dist/browser --root-mode upward", - "build:node": "cross-env BABEL_ENV=node babel src --out-dir dist --root-mode upward --source-maps", - "build:node:async": "cross-env BABEL_ENV=node:async babel src/node --out-dir dist --root-mode upward --source-maps", - "// build:node:test": "cross-env BABEL_ENV=node:test babel test --out-dir build-test --root-mode upward --source-maps", + "build:browser": "cross-env BABEL_ENV=browser babel src --extensions \".js\" --out-dir dist/browser --root-mode upward", + "build:node": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", + "build:node:async": "cross-env BABEL_ENV=node:async babel src/node --extensions \".js\" --out-dir dist --root-mode upward --source-maps", + "// build:node:test": "cross-env BABEL_ENV=node:test babel test --extensions \".js\" --out-dir build-test --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "package": "npm pack", diff --git a/packages/embarkjs-whisper/package.json b/packages/embarkjs-whisper/package.json index a0c64c03bb..75f69f4869 100644 --- a/packages/embarkjs-whisper/package.json +++ b/packages/embarkjs-whisper/package.json @@ -35,10 +35,10 @@ ], "scripts": { "build": "npm-run-all build:**", - "build:browser": "cross-env BABEL_ENV=browser babel src --out-dir dist/browser --root-mode upward", - "build:node": "cross-env BABEL_ENV=node babel src --out-dir dist --root-mode upward --source-maps", - "build:node:async": "cross-env BABEL_ENV=node:async babel src/node --out-dir dist --root-mode upward --source-maps", - "// build:node:test": "cross-env BABEL_ENV=node:test babel test --out-dir build-test --root-mode upward --source-maps", + "build:browser": "cross-env BABEL_ENV=browser babel src --extensions \".js\" --out-dir dist/browser --root-mode upward", + "build:node": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", + "build:node:async": "cross-env BABEL_ENV=node:async babel src/node --extensions \".js\" --out-dir dist --root-mode upward --source-maps", + "// build:node:test": "cross-env BABEL_ENV=node:test babel test --extensions \".js\" --out-dir build-test --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "package": "npm pack", diff --git a/packages/embarkjs/package.json b/packages/embarkjs/package.json index 68448319be..81d7697b31 100644 --- a/packages/embarkjs/package.json +++ b/packages/embarkjs/package.json @@ -35,10 +35,10 @@ ], "scripts": { "build": "npm-run-all build:**", - "build:browser": "cross-env BABEL_ENV=browser babel src --out-dir dist/browser --root-mode upward", - "build:node": "cross-env BABEL_ENV=node babel src --out-dir dist --root-mode upward --source-maps", - "build:node:async": "cross-env BABEL_ENV=node:async babel src/node --out-dir dist --root-mode upward --source-maps", - "build:node:test": "cross-env BABEL_ENV=node:test babel test --out-dir build-test --root-mode upward --source-maps", + "build:browser": "cross-env BABEL_ENV=browser babel src --extensions \".js\" --out-dir dist/browser --root-mode upward", + "build:node": "cross-env BABEL_ENV=node babel src --extensions \".js\" --out-dir dist --root-mode upward --source-maps", + "build:node:async": "cross-env BABEL_ENV=node:async babel src/node --extensions \".js\" --out-dir dist --root-mode upward --source-maps", + "build:node:test": "cross-env BABEL_ENV=node:test babel test --extensions \".js\" --out-dir build-test --root-mode upward --source-maps", "ci": "npm run qa", "clean": "npm run reset", "package": "npm pack",