Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf9160 example "modem_tcp_client.rs" crashes on nrf9151 #3471

Open
tpisto opened this issue Oct 28, 2024 · 2 comments
Open

nrf9160 example "modem_tcp_client.rs" crashes on nrf9151 #3471

tpisto opened this issue Oct 28, 2024 · 2 comments

Comments

@tpisto
Copy link

tpisto commented Oct 28, 2024

Error:

TRACE ipc 2
└─ embassy_net_nrf91::{impl#3}::poll @ /embassy-net-nrf91/src/lib.rs:334 
ERROR panicked at 'assertion failed: `(left == right)`'
diff < left / right >
<32
>16
└─ embassy_net_nrf91::{impl#3}::poll @ /embassy-net-nrf91/src/lib.rs:348 

By removing line 348 assert_eq!(rx_data_len, LIST_LEN); the example works 👍 .

With nrf9151 the rx_data_len at line 348 is 32 instead of 16 (which is LIST_LEN).

@lulf
Copy link
Member

lulf commented Oct 29, 2024

In that case, I think we should probably introduce some features on the net-nrf91 crate to configure both the correct pac crate, as well as the appropriate constants. Thanks for testing it out!

@Dirbaio
Copy link
Member

Dirbaio commented Oct 29, 2024

I think there's no guarantee the list size will stay constant in the future. Maybe we should make it a non-constant.

Also I think the list sizes don't have to match in both directions. We can make our list size a constant in the app->modem direction, and trust the modem's size for the modem->app direction (or maybe they're the other way around, not sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants