Ignore missing sourcemap if referenced file does not exist #55
Conversation
index.js
Outdated
| if (fs.existsSync(sourceMapPath)) { | ||
| sourceMap.content = JSON.parse(fs.readFileSync(sourceMapPath)); | ||
| } else { | ||
| console.warn(`[WARN] (broccoli-uglify-sourcemap) "${url}" referenced in "${relativePath}" could not be found`); |
There was a problem hiding this comment.
Can you modify this to use this.console.warn (then initialize this.console = options.console || console in the constructor)? There is at least one other usage of console.warn also.
The idea is to have ember-cli-uglify pass in a “custom console” which uses our UI object and avoiding needing to manually check for --silent...
There was a problem hiding this comment.
yeah, I noticed that too, but wanted to address it in a separate PR. your point about honoring --silent is valid though, this should probably be something like } else if (!this.silent) {.
Turbo87
force-pushed
the
missing-sourcemaps
branch
from
5987c38
to
dbb6616
Compare
| @@ -45,6 +46,9 @@ function third(){ | |||
| "something.css": "#id { | |||
| background: white; | |||
| }", | |||
| "with-broken-sourcemap.js": "function meaningOfLife(){throw new Error(42)} | |||
| //# sourceMappingURL=with-broken-sourcemap.map", | |||
| "with-broken-sourcemap.map": "{\\"version\\":3,\\"sources\\":[\\"0\\"],\\"names\\":[\\"meaningOfLife\\",\\"Error\\"],\\"mappings\\":\\"AAAA,SAASA,gBAEP,MAAM,IAAIC,MADa\\",\\"file\\":\\"with-broken-sourcemap.js\\"}", | |||
There was a problem hiding this comment.
Is there a way we can output "sources: ["with-broken-sourcemap.js] instead of sources: ["0"]?
There was a problem hiding this comment.
I don't know. can you explain why that would be useful or more correct than what we currently have?
Resolves #53