Remove Bower support. #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
remove-bower-components-support
branch
from
2263389 to
1b21e24
Compare
Retrieving `ember-template-compiler` from `bower_components` is only
required when using Ember versions older than 2.12. Bower itself is
essentially deprecated, this removes the fallback code to use
`bower_components/ember/ember-template-compiler.js` and improves the
error message when we can't actually find `ember-source`.
You can still provide a custom path to the template compiler (and
therefore use Bower if you wish) by:
```js
// ember-cli-build.js
module.exports = function(defaults) {
let app = new EmberApp(defaults, {
'ember-cli-htmlbars': {
templateCompilerPath: `some_path/to/ember-template-compiler.js`,
}
});
};
```
rwjblue
force-pushed
the
remove-bower-components-support
branch
from
1b21e24 to
87c8886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieving
ember-template-compilerfrombower_componentsis only required when using Ember versions older than 2.12. Bower itself is essentially deprecated, this removes the fallback code to usebower_components/ember/ember-template-compiler.jsand improves the error message when we can't actually findember-source.You can still provide a custom path to the template compiler (and therefore use Bower if you wish) by:
Closes #487