Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate + Remove Ember Data Functionality #289

Closed
rwjblue opened this issue May 1, 2019 · 7 comments · Fixed by #308
Closed

Deprecate + Remove Ember Data Functionality #289

rwjblue opened this issue May 1, 2019 · 7 comments · Fixed by #308

Comments

@rwjblue
Copy link
Member

rwjblue commented May 1, 2019

As of emberjs/data#6077, ember-data will no longer depend on ember-fetch directly (but will continue to use it if it is present).

We should deprecate usage of all code in addon/ except addon/ajax.ts (since it provides functionality for the ember-data adapter mixin, which will not be required as of ember-data@3.10+ and possibly ember-data@3.9.2).

@rwjblue
Copy link
Member Author

rwjblue commented May 2, 2019

/cc @nlfurniss @xg-wang for visibility

@xg-wang
Copy link
Member

xg-wang commented May 3, 2019

@rwjblue Does it makes sense to add deprecation when next ember-data LTS version (3.12) comes out then major bump to remove utils?

@rwjblue
Copy link
Member Author

rwjblue commented May 9, 2019

ember-data@3.9.2 was released dropping the dependency on ember-fetch (with some more tweaks coming in a 3.9.3).

@rwjblue
Copy link
Member Author

rwjblue commented May 9, 2019

Does it makes sense to add deprecation when next ember-data LTS version (3.12) comes out then major bump to remove utils?

I don't think we have to be terribly concerned with the timing here; its probably fine to deprecate whenever we have the time...

@nlfurniss
Copy link
Collaborator

I should have chimed in earlier, sorry.

The utils are useful helpers in constructing one-off ajax requests using ember-fetch, so I'm concerned about deprecating them

@xg-wang
Copy link
Member

xg-wang commented Jun 6, 2019

@rwjblue @nlfurniss These utils are private in ember-data. How's your opinion on keeping them in ember-fetch and let ember-data depends/rollsup these?

Copy link
Member Author

rwjblue commented Jun 6, 2019

ember-data should definitely not depend on this addon (that was the reason for my work in ember-data for 3.10.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants