-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operation outputFileSync is not allowed to use #477
Comments
cc @SparshithNR |
Can you check the version of |
I think this is basically what @bendemboski describes in broccolijs/broccoli-plugin#50. |
I can confirm that for our app, upgrading |
@stefanpenner why did you close the issue? is it fixed? |
@Turbo87 yes it is fixed (broccoli-output-wrapper 3.2.0 -> 3.2.1) , please be sure that your lock file isn't retaining an old version of |
@stefanpenner - This is still pretty tricky and easy to cause folks to stumble, I think we should land and release broccolijs/broccoli-plugin#50 then bump our minimum version on broccoli-plugin here. |
FWIW this is the dependency chain:
|
broccoli-plugin released as v4.0.2 🎉 For those running into this issue, please ensure your dependencies are updated. Re-roll your lockfile, and all should be back to normal. |
I agree with @rwjblue. It looks like the actual issue here is an outdated dependency specification somewhere. Asking people to cycle their lockfiles is just hiding the root cause 😉 |
@Turbo87 sorta, new users are unaffected. Users who don't update dependencies, will never see the fix. They must update dependencies. I'll be sure to update broccoli-concat and merge-trees as well, but anything else in the longtail is just "to bad". Unfortunately, this is a trade-off folks using lockfiles will get, using a lockfile then requires a level of lockfile hygiene or sadness will occur. |
@stefanpenner Isn't it also the responsibility of library maintainers to specify versions of their dependencies that actually work with their library? If |
@kpfefferle not really ember-fetch is responsible to specify the versions of it's dependencies, known to work at the time of the authoring. If a transitive happens to break, and then fix itself it's a gray area. As the shear volume of transitive dependencies patch versions due to one break or another, would result in these libraries releasing near daily, that simply isn't possible to support or commit too. |
FWIW I disagree. I very much think that it is the responsibility of the libraries to declare correct dependency constraints. |
@Turbo87 sounds fair, I welcome additional contributions to help keep up with that work load. |
After trying to update from v7.1.0 to v8.0.0 we started to see the error below when trying to build our app:
This is likely a downstream issue in one of the broccoli dependencies, but I thought I should open it here too, because the ember-fetch update triggered this for us.
@stefanpenner @SparshithNR any clue what might be causing this?
The text was updated successfully, but these errors were encountered: