Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule: no-render-modifiers #1901

Closed
NullVoxPopuli opened this issue Jun 26, 2023 · 0 comments · Fixed by #1902
Closed

New Rule: no-render-modifiers #1901

NullVoxPopuli opened this issue Jun 26, 2023 · 0 comments · Fixed by #1902
Labels
enhancement New Rule Idea for a new lint rule

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Jun 26, 2023 •
edited
Loading

I will be implementing this

Some context for those alarmed by this issue, this blog post from 2021: https://nullvoxpopuli.com/avoiding-lifecycle
For eslint-plugin-ember, this will forbid the imports (for gjs/gts, but also if folks try getting clever and import and rename the modifiers to get around the template-lint)
Implementation: #1902

But first! I gotta finish the template-lint PR: ember-template-lint/ember-template-lint#2554
@NullVoxPopuli NullVoxPopuli changed the title New Rule: forbid-render-modifiers New Rule: no-render-modifiers Jun 26, 2023
This was referenced Jun 26, 2023
Merged
Merged
@bmish bmish added enhancement New Rule Idea for a new lint rule labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New Rule Idea for a new lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new rule no-at-ember-render-modifiers NullVoxPopuli/eslint-plugin-ember
2 participants
@NullVoxPopuli @bmish