no-new-mixins: getSourceModuleName should only be called on a CallExpression, MemberExpression or Identifier

[buschtoens]

AssertionError [ERR_ASSERTION]: `getSourceModuleName` should only be called on a `CallExpression`, `MemberExpression` or `Identifier`
    at getSourceModuleName (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:46:5)
    at getSourceModuleName (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:42:12)
    at /Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:31:49
    at Array.some (<anonymous>)
    at /Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:30:36
    at Array.find (<anonymous>)
    at Object.getSourceModuleNameForIdentifier (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:29:6)
    at isEmberCoreModule (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/ember.js:213:46)
    at Object.isEmberMixin (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/ember.js:259:10)
    at ClassDeclaration (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/rules/no-new-mixins.js:36:19)

The above error appears to be triggered by code like:

test('basic functionality', function(this: TestContext, assert) {
  class TestObject extends this.ContainerObject {
    // ...
  }
});

[buschtoens]

Same for no-attrs-in-components.

AssertionError [ERR_ASSERTION]: `getSourceModuleName` should only be called on a `CallExpression`, `MemberExpression` or `Identifier`
    at getSourceModuleName (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:46:5)
    at getSourceModuleName (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:42:12)
    at /Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:31:49
    at Array.some (<anonymous>)
    at /Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:30:36
    at Array.find (<anonymous>)
    at Object.getSourceModuleNameForIdentifier (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:29:6)
    at isEmberCoreModule (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/ember.js:213:46)
    at isEmberComponent (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/ember.js:246:10)
    at ClassDeclaration (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/rules/no-attrs-in-components.js:34:13)

[buschtoens]

no-get is affected as well.

AssertionError [ERR_ASSERTION]: `getSourceModuleName` should only be called on a `CallExpression`, `MemberExpression` or `Identifier`
    at getSourceModuleName (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:46:5)
    at getSourceModuleName (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:42:12)
    at /Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:31:49
    at Array.some (<anonymous>)
    at /Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:30:36
    at Array.find (<anonymous>)
    at Object.getSourceModuleNameForIdentifier (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/import.js:29:6)
    at isEmberCoreModule (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/ember.js:213:46)
    at isEmberArrayProxy (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/ember.js:271:10)
    at Object.isEmberProxy (/Users/jan/open-source/decorators/node_modules/eslint-plugin-ember/lib/utils/ember.js:288:10)

I guess the issue is that isEmberCoreModule incorrectly passes the node through to getSourceModuleNameForIdentifier?

[rwjblue]

@buschtoens - Can you check what node type is being passed (also we should update that assertion to tell you what was passed in addition to what is allowed, the message as it stands is a bit hard to debug)?

[rwjblue]

In general, getSourceModuleNameForIdentifier is only going to call getSourceModuleName on an import specifier, but when the node.superClass is not itself an Identifier (in this case its a member expression) there is an issue.

https://astexplorer.net/#/gist/b736a0d02d00957083b4a0118403fd7d/38043d9bc98eba1ab831d7ca16ddf57435504583

getSourceModuleNameForIdentifier is passed the node.superClass (which normally is an Identifier, but in this case is a MemberExpression):

eslint-plugin-ember/lib/utils/ember.js

Lines 213 to 216 in 82acc5b

	const superClassImportPath = importUtils.getSourceModuleNameForIdentifier(
	context,
	node.superClass
	);

Then getSourceModuleNameForIdentifier calls getSourceModuleName(node) with that MemberExpression and causes the error you are seeing:

eslint-plugin-ember/lib/utils/import.js

Lines 30 to 32 in 82acc5b

	importDeclaration.specifiers.some(
	(specifier) => specifier.local.name === getSourceModuleName(node)
	)

Ultimately, I think we should update isEmberCoreModule to return false when we spot a non Identifier as node.superClass.

[bmish]

Opened fix in #906.