Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route-specific components end up severely over-nested #39

Open
chriskrycho opened this issue May 19, 2016 · 0 comments
Open

Route-specific components end up severely over-nested #39

chriskrycho opened this issue May 19, 2016 · 0 comments

Comments

@chriskrycho
Copy link

We have a couple components that are only used on specific routes. It appears (I haven't dug into the migrator internals yet) that the intent is for route-specific components to live as children of the relevant routes. This makes good sense. However, the migrator (and perhaps the proposed pattern? Not sure) currently seems a bit... enthusiastic about the nesting (this is all under src/ui/routes):

nesting

It seems like the actual structure converted structure here should be something like this instead:

routes/
  checkout/
    place-order/
      -components/
        order-submission/
          olo-payment/
            olo-billing-scheme/
          create-card/

Obviously these can (and in several cases would) simply be moved to the general src/ui/components directory. My concern is just about all the extra checkout nesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant