You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a couple components that are only used on specific routes. It appears (I haven't dug into the migrator internals yet) that the intent is for route-specific components to live as children of the relevant routes. This makes good sense. However, the migrator (and perhaps the proposed pattern? Not sure) currently seems a bit... enthusiastic about the nesting (this is all under src/ui/routes):
It seems like the actual structure converted structure here should be something like this instead:
Obviously these can (and in several cases would) simply be moved to the general src/ui/components directory. My concern is just about all the extra checkout nesting.
The text was updated successfully, but these errors were encountered:
We have a couple components that are only used on specific routes. It appears (I haven't dug into the migrator internals yet) that the intent is for route-specific components to live as children of the relevant routes. This makes good sense. However, the migrator (and perhaps the proposed pattern? Not sure) currently seems a bit... enthusiastic about the nesting (this is all under
src/ui/routes
):It seems like the actual structure converted structure here should be something like this instead:
Obviously these can (and in several cases would) simply be moved to the general
src/ui/components
directory. My concern is just about all the extracheckout
nesting.The text was updated successfully, but these errors were encountered: