-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong env in /tests while running ember server
#80
Comments
This is due to the usage of storeConfigInMeta usage:
From here: https://github.com/tildeio/ember-cli-fastboot/blob/master/index.js#L47 By default storeConfigInMeta is true, but ember-cli-fastboot forces it to be false (for all commands). We need it to be false for commands related to fastboot, but we may be able to change that override to only apply when running a fastboot related command. Would you mind submitting a PR moving that assignment up into the guard just above? |
Done, if that's what you meant. Looks like it was inside the guard at a certain point. |
HA! Yeah, I knew I remembered doing it differently initially. 😸 |
This was the commit that changed the behavior: 2618e9f Do you think this may be still valid? |
This should be fixed now. |
Symptom:
http://localhost:4200/tests
is incorrectly indevelopment
mode while runningember server
http://localhost:4200/tests
is correctly intest
mode while runningember test --server
If
ember-cli-fastboot
is removed frompackage.json
, the erroneous behavior disappear.The text was updated successfully, but these errors were encountered: