Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong env in /tests while running ember server #80

Closed
zeppelin opened this issue Dec 21, 2015 · 5 comments
Closed

Wrong env in /tests while running ember server #80

zeppelin opened this issue Dec 21, 2015 · 5 comments

Comments

@zeppelin
Copy link
Contributor

Symptom:

  1. http://localhost:4200/tests is incorrectly in development mode while running ember server
  2. http://localhost:4200/tests is correctly in test mode while running ember test --server

If ember-cli-fastboot is removed from package.json, the erroneous behavior disappear.

$ ember -v
version: 2.2.0-beta.1
node: 0.12.1
npm: 2.14.10
os: darwin x64
@rwjblue
Copy link
Member

rwjblue commented Dec 21, 2015

This is due to the usage of storeConfigInMeta usage:

app.options.storeConfigInMeta = false;

From here: https://github.com/tildeio/ember-cli-fastboot/blob/master/index.js#L47


By default storeConfigInMeta is true, but ember-cli-fastboot forces it to be false (for all commands). We need it to be false for commands related to fastboot, but we may be able to change that override to only apply when running a fastboot related command.

Would you mind submitting a PR moving that assignment up into the guard just above?

@zeppelin
Copy link
Contributor Author

Done, if that's what you meant. Looks like it was inside the guard at a certain point.

@rwjblue
Copy link
Member

rwjblue commented Dec 21, 2015

HA! Yeah, I knew I remembered doing it differently initially. 😸

@zeppelin
Copy link
Contributor Author

This was the commit that changed the behavior: 2618e9f

Do you think this may be still valid?

@tomdale
Copy link
Contributor

tomdale commented Jun 24, 2016

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants