Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-rfc: deprecate Store service extending EmberObject #8874

Closed
runspired opened this issue Sep 17, 2023 · 4 comments
Closed

pre-rfc: deprecate Store service extending EmberObject #8874

runspired opened this issue Sep 17, 2023 · 4 comments

Comments

@runspired
Copy link
Contributor

runspired commented Sep 17, 2023

Currently Store extends from EmberObject. This is one of the last few entanglements EmberData has with the Ember framework directly.

We would like to RFC deprecating any inherited EmberObject methods or behaviors to support #8147 and to broaden our compatibility with a wider range of Ember.js versions as well.

This does not need to be a very involved RFC. Roughly equivalent to [https://github.com/emberjs/rfcs/pull/745]. The primary impact will be that anyone using Store.reopen or Store.extend will need to instead use native class extends. class Store extends BaseStore {}

@thevinitgupta
Copy link

Could you provide more context?

@runspired
Copy link
Contributor Author

@thevinitgupta added

@runspired
Copy link
Contributor Author

@runspired
Copy link
Contributor Author

RFC emberjs/rfcs#1026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants