Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3.4+] polyfillUUID isn't anymore working when there was added over @embroider/macros option #9508

Closed
mkszepp opened this issue Jul 10, 2024 · 1 comment · Fixed by #9580
Assignees

Comments

@mkszepp
Copy link
Contributor

mkszepp commented Jul 10, 2024

Starting with ember-data 5.3.4+ we are seeing a lot of randomUUID errors.

L.randomUUID is not a function. (In 'L.randomUUID()', 'L.randomUUID' is undefined)

In our app we are using this code part (since ember 4.6)

let app = new EmberApp(defaults, {
  '@embroider/macros': {
      setConfig: {
        '@ember-data/store': {
          polyfillUUID: true,
        },
      },
    },
});

Now i have discovered, that this was changes in #9265 to:

let app = new EmberApp(defaults, {
  emberData: {
    polyfillUUID: true
  },
});

I didn't found this braking change in changelogs of v5.3.4.
Its nice to simplify this config, because a lot of apps didn't configured correctly, but for our apps this change was braking as we havn't seen a changelog for that one.

In additional also inside the app there is still documented the old way (which isn't anymore working).

let app = new EmberApp(defaults, {
'@embroider/macros': {
setConfig: {
'@ember-data/store': {
polyfillUUID: true,
},
},
},
});

let app = new EmberApp(defaults, {
'@embroider/macros': {
setConfig: {
'@ember-data/store': {
polyfillUUID: true
},
},
},
});

@mkszepp mkszepp changed the title [5.3.4+] polyfillUUID isn't anymore working when there was added over ´@embroider/macros` option [5.3.4+] polyfillUUID isn't anymore working when there was added over @embroider/macros option Jul 10, 2024
@runspired runspired self-assigned this Jul 10, 2024
@runspired
Copy link
Contributor

thanks, I think we should just remove the old docs where they got forgotten as we no longer use macros configs but macros global configs instead in order to support v2 addons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants