Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a service is injected in a router the routes unit tests fail #218

Closed
olivierlesnicki opened this issue Feb 22, 2016 · 3 comments
Closed

When a service is injected in a router the routes unit tests fail #218

olivierlesnicki opened this issue Feb 22, 2016 · 3 comments

Comments

@olivierlesnicki
Copy link

See adopted-ember-addons/ember-metrics#43

When a service is injected in a router the routes unit tests fail unless that service is injected using needs. It seems the route unit tests create a router instance. Is there a way to prevent that behaviour globally?
@rwjblue
Copy link
Member

rwjblue commented Feb 23, 2016

no

@olivierlesnicki
Copy link
Author

3o7qdsovfaco9b3mlo

@rwjblue
Copy link
Member

rwjblue commented Nov 8, 2016

Hehe, sorry for the terseness, but great gif

@Turbo87 Turbo87 closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @Turbo87 @olivierlesnicki