-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better assertion message when ember asserts. #247
Comments
👍 discovered this while pairing with @kiwiupover @trentmwillis - I'd love your thoughts here... |
I am happy to add a |
I think I'm missing something, it sounds like the suggestion is to add |
In an integration test where a component is instantiated the test is the outside context. Ember when makes an assertion at that point the test is the object that ember is using in the assertion object hench |
Okay, thanks that makes more sense. I think this is something that should be handled in ember-test-helpers, as it seems like it could also apply to ember-mocha and, as it stands, it seems primarily related to an Ember-specific debuggability issue. Though if there are other common use cases, feel free to open an issue upstream with QUnit. |
👍 - Sounds good, I'll work up a PR for ember-test-helpers and we can discuss in more detail there... |
@rwjblue would you mind if I write the PR. |
seems like this was resolved by emberjs/ember-test-helpers#181 |
The object that the error is thrown on is returned as
[object Object]
.Assertion Failed: You modified image1xFile twice on [object Object] in a single render.
I believe ember overwrites the toString for ember created objects like components to return the name of the object but the ember-quint is not overwriting the
toString
method for objects it creates.@rwjblue maybe you can give more context here.
The text was updated successfully, but these errors were encountered: