From ba1249657e314cb926349efbabb226ce21c929d8 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Mon, 12 Jun 2023 10:18:47 -0400 Subject: [PATCH 1/2] Remove hasEmberVersion --- addon-test-support/adapter.js | 17 ----------------- tests/acceptance/basic-test.js | 5 ----- tests/integration/setup-rendering-test-test.js | 5 ----- tests/integration/setup-test-test.js | 12 +----------- 4 files changed, 1 insertion(+), 38 deletions(-) diff --git a/addon-test-support/adapter.js b/addon-test-support/adapter.js index 69afb39f..3f643e8b 100644 --- a/addon-test-support/adapter.js +++ b/addon-test-support/adapter.js @@ -1,6 +1,5 @@ import Ember from 'ember'; import * as QUnit from 'qunit'; -import hasEmberVersion from '@ember/test-helpers/has-ember-version'; function unhandledRejectionAssertion(current, error) { let message, source; @@ -59,22 +58,6 @@ let Adapter = Ember.Test.Adapter.extend({ done(); } }, - - // clobber default implementation of `exception` will be added back for Ember - // < 2.17 just below... - exception: null, }); -// Ember 2.17 and higher do not require the test adapter to have an `exception` -// method When `exception` is not present, the unhandled rejection is -// automatically re-thrown and will therefore hit QUnit's own global error -// handler (therefore appropriately causing test failure) -if (!hasEmberVersion(2, 17)) { - Adapter = Adapter.extend({ - exception(error) { - unhandledRejectionAssertion(QUnit.config.current, error); - }, - }); -} - export default Adapter; diff --git a/tests/acceptance/basic-test.js b/tests/acceptance/basic-test.js index 2854e223..d2306237 100644 --- a/tests/acceptance/basic-test.js +++ b/tests/acceptance/basic-test.js @@ -10,13 +10,8 @@ import { click, } from '@ember/test-helpers'; import { setResolverRegistry } from '../helpers/resolver'; -import hasEmberVersion from '@ember/test-helpers/has-ember-version'; module('setupApplicationTest tests', function (hooks) { - if (!hasEmberVersion(2, 4)) { - return; - } - const Router = EmberRouter.extend({ location: 'none' }); Router.map(function () { this.route('widgets'); diff --git a/tests/integration/setup-rendering-test-test.js b/tests/integration/setup-rendering-test-test.js index 0e8c3392..e3a57c52 100644 --- a/tests/integration/setup-rendering-test-test.js +++ b/tests/integration/setup-rendering-test-test.js @@ -5,13 +5,8 @@ import { hbs } from 'ember-cli-htmlbars'; import { setupRenderingTest } from 'ember-qunit'; import { render } from '@ember/test-helpers'; import { setResolverRegistry } from '../helpers/resolver'; -import hasEmberVersion from '@ember/test-helpers/has-ember-version'; module('setupRenderingTest tests', function (hooks) { - if (!hasEmberVersion(2, 4)) { - return; - } - hooks.beforeEach(function () { setResolverRegistry({}); }); diff --git a/tests/integration/setup-test-test.js b/tests/integration/setup-test-test.js index 5bd318df..ff21eda9 100644 --- a/tests/integration/setup-test-test.js +++ b/tests/integration/setup-test-test.js @@ -2,14 +2,9 @@ import { module, test } from 'qunit'; import Service, { inject as injectService } from '@ember/service'; import Component from '@ember/component'; import { setupTest } from 'ember-qunit'; -import hasEmberVersion from '@ember/test-helpers/has-ember-version'; import { setResolverRegistry } from '../helpers/resolver'; module('setupTest tests', function (hooks) { - if (!hasEmberVersion(2, 4)) { - return; - } - hooks.beforeEach(function () { setResolverRegistry({}); }); @@ -63,12 +58,7 @@ module('setupTest tests', function (hooks) { }) ); - let subject; - if (hasEmberVersion(2, 12)) { - subject = this.owner.lookup('component:foo-bar'); - } else { - subject = this.owner._lookupFactory('component:foo-bar').create(); - } + let subject = this.owner.lookup('component:foo-bar'); assert.equal(subject.someMethod(), 'hello thar!'); }); From b783fb231cae43229e9147d124a2ed7e0d041b12 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Mon, 12 Jun 2023 10:21:07 -0400 Subject: [PATCH 2/2] Remove unused function --- addon-test-support/adapter.js | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/addon-test-support/adapter.js b/addon-test-support/adapter.js index 3f643e8b..b7202b04 100644 --- a/addon-test-support/adapter.js +++ b/addon-test-support/adapter.js @@ -1,29 +1,6 @@ import Ember from 'ember'; import * as QUnit from 'qunit'; -function unhandledRejectionAssertion(current, error) { - let message, source; - - if (typeof error === 'object' && error !== null) { - message = error.message; - source = error.stack; - } else if (typeof error === 'string') { - message = error; - source = 'unknown source'; - } else { - message = 'unhandledRejection occurred, but it had no message'; - source = 'unknown source'; - } - - current.assert.pushResult({ - result: false, - actual: false, - expected: true, - message: message, - source: source, - }); -} - export function nonTestDoneCallback() {} let Adapter = Ember.Test.Adapter.extend({