Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types for @glimmer/interfaces #1296

Closed
ef4 opened this issue Dec 16, 2022 · 3 comments
Closed

Missing types for @glimmer/interfaces #1296

ef4 opened this issue Dec 16, 2022 · 3 comments

Comments

@ef4
Copy link
Contributor

ef4 commented Dec 16, 2022

Upgrading from 2.8.1 to 2.9.1 introduced a type error.

node_modules/@ember/test-helpers/public-types/@ember/test-helpers/setup-rendering-context.d.ts:4:40 - error TS2307: Cannot find module '@glimmer/interfaces' or its corresponding type declarations.

4 import type { ComponentInstance } from '@glimmer/interfaces';
                                         ~~~~~~~~~~~~~~~~~~~~~

Should @glimmer/interfaces be a peerDep? Maybe optional peerDep, since only typescript users would care?

@oliverlj
Copy link

Facing error too

../node_modules/@ember/test-helpers/public-types/@ember/test-helpers/setup-rendering-context.d.ts(4,15): error TS2305: Module '"@glimmer/interfaces"' has no exported member 'ComponentInstance'.
../node_modules/@glimmer/reference/dist/types/lib/validators.d.ts(79,52): error TS2422: A class can only implement an object type or intersection of object types with statically known members.
../node_modules/@glimmer/runtime/dist/types/lib/component/curried-component.d.ts(6,87): error TS2677: A type predicate's type must be assignable to its parameter's type.
  Type 'CurriedComponentDefinition' is not assignable to type 'Maybe<Dict<unknown>>'.
    Type 'CurriedComponentDefinition' is not assignable to type 'Dict<unknown>'.
      Index signature for type 'string' is missing in type 'CurriedComponentDefinition'.
../node_modules/@glimmer/util/dist/types/lib/destroy.d.ts(3,69): error TS2677: A type predicate's type must be assignable to its parameter's type.
  Type 'SymbolDestroyable' is not assignable to type 'Maybe<Dict<unknown>>'.
    Type 'SymbolDestroyable' is not assignable to type 'Dict<unknown>'.
      Index signature for type 'string' is missing in type 'SymbolDestroyable'.
../node_modules/@types/ember__test-helpers/index.d.ts(56,18): error TS2724: '"@ember/test-helpers/setup-rendering-context"' has no exported member named 'rerender'. Did you mean 'render'?

@dfreeman
Copy link
Contributor

Should be fixed by #1304 / #1305

@chriskrycho
Copy link
Contributor

Indeed; and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants