Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read "maxlength" attribute instead of "maxLength" in "-guard-for-maxlength.ts" #1459

Closed
shubham88fru opened this issue Jul 22, 2024 · 2 comments · Fixed by #1464
Closed

Read "maxlength" attribute instead of "maxLength" in "-guard-for-maxlength.ts" #1459

shubham88fru opened this issue Jul 22, 2024 · 2 comments · Fixed by #1464

Comments

@shubham88fru
Copy link
Contributor

I had opened this a while back but didn't end up creating a PR.

background: The following piece of code in "-guard-for-maxlength.ts" reads "maxLength" (camelcase") attribute instead of "maxlength" (lowercase)

As per this MDN document, the actual attribute is "maxlength" (lowercase) and NOT "maxLength" (camel case).

In fact, in the same file, few lines below, the following line of code does this correctly.

const maxlength = element.getAttribute('maxlength');

I think, this should be fixed for consistency and correctness.
Please let me know if I can work on this and can create a PR.

Thanks.

@shubham88fru
Copy link
Contributor Author

shubham88fru commented Jul 22, 2024

@rwjblue @kategengler - I'd be happy to do this change as my first contribution to open source. Please have a look.

@shubham88fru
Copy link
Contributor Author

@NullVoxPopuli - created PR for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant