We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I had opened this a while back but didn't end up creating a PR.
background: The following piece of code in "-guard-for-maxlength.ts" reads "maxLength" (camelcase") attribute instead of "maxlength" (lowercase)
ember-test-helpers/addon/addon-test-support/@ember/test-helpers/dom/-guard-for-maxlength.ts
Line 22 in 3b83f12
As per this MDN document, the actual attribute is "maxlength" (lowercase) and NOT "maxLength" (camel case).
In fact, in the same file, few lines below, the following line of code does this correctly.
Line 41 in 3b83f12
I think, this should be fixed for consistency and correctness. Please let me know if I can work on this and can create a PR.
Thanks.
The text was updated successfully, but these errors were encountered:
@rwjblue @kategengler - I'd be happy to do this change as my first contribution to open source. Please have a look.
Sorry, something went wrong.
maxlength
maxLength
@NullVoxPopuli - created PR for this change.
Successfully merging a pull request may close this issue.
I had opened this a while back but didn't end up creating a PR.
background: The following piece of code in "-guard-for-maxlength.ts" reads "maxLength" (camelcase") attribute instead of "maxlength" (lowercase)
ember-test-helpers/addon/addon-test-support/@ember/test-helpers/dom/-guard-for-maxlength.ts
Line 22 in 3b83f12
As per this MDN document, the actual attribute is "maxlength" (lowercase) and NOT "maxLength" (camel case).
In fact, in the same file, few lines below, the following line of code does this correctly.
ember-test-helpers/addon/addon-test-support/@ember/test-helpers/dom/-guard-for-maxlength.ts
Line 41 in 3b83f12
I think, this should be fixed for consistency and correctness.
Please let me know if I can work on this and can create a PR.
Thanks.
The text was updated successfully, but these errors were encountered: