Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for model requires inclusion of any other "referenced" model into needs. #6

Closed
abuiles opened this issue Dec 19, 2014 · 5 comments

Comments

@abuiles
Copy link
Member

abuiles commented Dec 19, 2014

abuiles> dgeb: there is something else that has been buggy my and would like to hear your thoughts on, every time I create a unit test for a model, I have to put in need all the other models which it references in the belongsto and hasMany
6:24 PM all good until there
6:25 PM the really annoying part is that I also have to put all the model which those models reference so I end-up with a bunch of things in "needs" which are not necessarily related to the test
6:26 PM abuiles: yeah, that's a real annoyance :/
6:27 PM we need smarter model tests
6:27 PM this shouldn't be necessary

@rwjblue
Copy link
Member

rwjblue commented Dec 20, 2014

Related to ember-cli/ember-cli#2714.

@rwjblue
Copy link
Member

rwjblue commented Dec 20, 2014

Sorry, I meant https://github.com/rwjblue/ember-qunit/issues/108 (derp).

@abuiles
Copy link
Member Author

abuiles commented Dec 20, 2014

@Turbo87
Copy link
Member

Turbo87 commented Oct 14, 2017

emberjs/rfcs#229 will finally fix this

@rwjblue
Copy link
Member

rwjblue commented Nov 30, 2017

RFC landed, closing...

@rwjblue rwjblue closed this as completed Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants