Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUEST] Internals should prefer generic array methods over prototype_extensions #15501

Closed
7 of 16 tasks
Serabe opened this issue Jul 13, 2017 · 9 comments
Closed
7 of 16 tasks
Labels

Comments

@Serabe
Copy link
Member

Serabe commented Jul 13, 2017

This supersedes #10899 that is stale.

The goal here is merely to decouple the internals from the the observable based prototype extensions.
This will hopefully give us the flexibility to make a future call re: prototype extensions in general. This also eases the pain of using ember with prototype extensions disabled.

All this is accomplished without breaking semver in anyway.

More todo:

  • Merge Enumerable + NativeArray
  • Merge MutableEnumerable + MutableArray
  • Deprecate Enumerable as [bugfix release]
  • Deprecate MutableEnumerable as [bugfix release]
@alvincrespo
Copy link
Contributor

@Serabe How can I help? This is my first time diving into Ember internals.

@acorncom acorncom changed the title [EPIC] Internals should prefer generic array methods over prototype_extensions [QUEST] Internals should prefer generic array methods over prototype_extensions Jan 10, 2018
@acorncom acorncom added the Quest label Jan 10, 2018
@Serabe
Copy link
Member Author

Serabe commented May 3, 2018

This might be closed as per #16048 (comment)

@Serabe
Copy link
Member Author

Serabe commented May 3, 2018

Removing labels to avoid people working on this until there is some clarification on the goal.

@Serabe
Copy link
Member Author

Serabe commented May 5, 2018

@mmun any update on this?

Thank you!

@mmun
Copy link
Member

mmun commented May 6, 2018

As far as internal refactors go, you should follow https://github.com/emberjs/rfcs/blob/array-functions/text/0323-array-functions.md#detailed-design.

@pixelhandler
Copy link
Contributor

@Serabe is this still an issue. Is there anything that remains TODO?

@Serabe
Copy link
Member Author

Serabe commented Sep 29, 2018

Don't really know. source needs to be checked.

@mmun
Copy link
Member

mmun commented Sep 29, 2018

@bekzod was working on this recently.

@locks
Copy link
Contributor

locks commented Jan 17, 2020

Thanks everyone for your help! Closing as there's no more work required here :)

@locks locks closed this as completed Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants