-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUEST] Internals should prefer generic array methods over prototype_extensions #15501
Comments
@Serabe How can I help? This is my first time diving into Ember internals. |
This might be closed as per #16048 (comment) |
Removing labels to avoid people working on this until there is some clarification on the goal. |
@mmun any update on this? Thank you! |
As far as internal refactors go, you should follow https://github.com/emberjs/rfcs/blob/array-functions/text/0323-array-functions.md#detailed-design. |
@Serabe is this still an issue. Is there anything that remains TODO? |
Don't really know. source needs to be checked. |
@bekzod was working on this recently. |
Thanks everyone for your help! Closing as there's no more work required here :) |
This supersedes #10899 that is stale.
objectAt
replace
remoteAt
insertAt
Prefer genericinsertAt
over prototype_extensions #16048The goal here is merely to decouple the internals from the the observable based prototype extensions.
This will hopefully give us the flexibility to make a future call re: prototype extensions in general. This also eases the pain of using ember with prototype extensions disabled.
All this is accomplished without breaking semver in anyway.
More todo:
The text was updated successfully, but these errors were encountered: