New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Canary] class helper invocation fails in dev mode #19518

Closed

patricklx opened this issue Apr 30, 2021 · 3 comments

Contributor

patricklx commented Apr 30, 2021

🐞 Describe the Bug

the invocation of the helper fails here https://github.com/emberjs/ember.js/blob/master/packages/%40ember/-internals/glimmer/lib/helper.ts#L194

before its also checked if .class actually exists or not. I guess it should also happen in getDebugName
https://github.com/emberjs/ember.js/blob/master/packages/%40ember/-internals/glimmer/lib/helper.ts#L164

Contributor

pzuraq commented May 3, 2021

Can you provide a reproduction or some steps for producing this error? As is, I'm not sure how to diagnose/fix this issue.

Contributor Author

patricklx commented May 4, 2021 •

edited

Loading

okay, right, i just noticed this happens when using helpers coming from local variables.
https://ember-twiddle.com/e03f28ed71a45e0e9daf7da76ff295fd?numColumns=2&openFiles=templates.application%5C.hbs%2Chelpers.my-helper%5C.js
I was unable to get it to build in ember-twiddle...
https://gitpod.io#snapshot/a23f617d-5ef3-4057-aa4a-24692b15fc5f

and it works when i add in my-helper.js

MyHelper.class = MyHelper

patricklx mentioned this issue

[Bugfix release] allow class-based helpers to work in strict-mode #19878

Merged

Contributor

NullVoxPopuli commented Jan 29, 2022

Is this still an issue? looks like a bugfix PR was merged

patricklx closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment