Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint for typescript should use ember stable types #197

Open
lukemelia opened this issue Sep 7, 2023 · 3 comments
Open

Blueprint for typescript should use ember stable types #197

lukemelia opened this issue Sep 7, 2023 · 3 comments

Comments

@lukemelia
Copy link
Contributor

Currently using old @types/ packages

@lukemelia
Copy link
Contributor Author

This may be complicated by the status of ember-cli's new app blueprint, which is used to generate the test-app. The approach to importing ember types need to be consistent.

@ef4
Copy link
Contributor

ef4 commented Sep 7, 2023

Possible prerequisite: emberjs/rfcs#952 (comment)

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Sep 7, 2023

I think we're blocked on ember-data not being compatible with the stable types.

Everyone is free to delete all the @types/ packages in favor of the stable built in types if they aren't using ember-data though.

Once ember-data is compatible with the ember stable types, the ember-cli blueprints will use those, and then we also use them.

See also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants