Upgrade @typescript-eslint/* #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
approved these changes
Nov 10, 2024
NullVoxPopuli
force-pushed
the
upgrade-typescript-eslint
branch
from
4f0c92d
to
5ba8610
Compare
…lets just let the user decide if they need it at all
…lets just let the user decide if they need it at all
NullVoxPopuli
commented
Nov 10, 2024
| @@ -4,8 +4,7 @@ | |||
|
|
|||
| // import type MyComponent from './components/my-component'; | |||
|
|
|||
| // Remove this once entries have been added! 👇 | |||
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | |||
There was a problem hiding this comment.
instead of adding new lint disables here, I've just commented out the whole thing
NullVoxPopuli
commented
Nov 10, 2024
| @@ -4,11 +4,11 @@ | |||
| import '@glint/environment-ember-loose'; | |||
| import '@glint/environment-ember-template-imports'; | |||
|
|
|||
| declare module '@glint/environment-ember-loose/registry' { | |||
There was a problem hiding this comment.
instead of adding new lint disables here, I've just commented out the whole thing
NullVoxPopuli
commented
Nov 10, 2024
| "@rollup/plugin-babel": "^6.0.4", | ||
| "babel-plugin-ember-template-compilation": "^2.2.5", | ||
| "concurrently": "^9.0.1", | ||
| "ember-source": "^5.4.0", | ||
| "ember-template-lint": "^6.0.0",<% if (packageManager === 'npm') { %> |
There was a problem hiding this comment.
diverging ember-eslint-parser versions causes eslint-plugin-ember to not be able to work with gjs/gts
mansona
approved these changes
Nov 11, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.