New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensureSafeComponent can be a no-op for classes on newer embers #1061

Closed

ef4 opened this issue Dec 22, 2021 · 0 comments · Fixed by #1155

Contributor

ef4 commented Dec 22, 2021

Starting with the ember-source 3.25 beta series, it became safe to invoke component classes directly with angle bracket invocation.

We should update to ensureSafeComponent so it leaves classes alone on those versions, instead of converting them to curried component definitions.

There's no bug here, it's just unnecessary work we can optimize away.

Windvis mentioned this issue

Turn ensureSafeComponent into a no-op for class values on Ember 3.25+ #1155

Merged

ef4 closed this as completed in #1155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment