Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and properly test reverse-exports package #1651

Closed
mansona opened this issue Oct 26, 2023 · 3 comments
Closed

Implement and properly test reverse-exports package #1651

mansona opened this issue Oct 26, 2023 · 3 comments
Assignees
@lolmaus

Comments

@mansona
Copy link
Member

mansona commented Oct 26, 2023 •
edited
Loading

It's probably best to create a new branch and PR that cherry-picks this commit: 79e377b

then start adding test cases, and once we're happy we can start on the implementation 👍
@mansona mansona converted this from a draft issue Oct 26, 2023
@mansona mansona mentioned this issue Oct 26, 2023
Merged
@lolmaus lolmaus moved this from Todo to In Progress in Mainmatter Embroider Team Oct 26, 2023
@lolmaus
Copy link
Collaborator

lolmaus commented Oct 30, 2023

#1652

@lolmaus
Copy link
Collaborator

lolmaus commented Oct 30, 2023

Some references:

@mansona
Copy link
Member Author

mansona commented Nov 20, 2023

Fixed in #1652

@mansona mansona closed this as completed Nov 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mainmatter Embroider Team Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolmaus lolmaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lolmaus @mansona