Regression in rebuild times introduced in @embroider/compat@3.3.1 and @embroider/core@3.4.1

[achambers]

Hi 👋

When I upgraded @embroider/compat and @embroider/core to the versions below I noticed a large rebuild time regression.

- "@embroider/compat": "^3.2.3",
+ "@embroider/compat": "^3.3.0",

- "@embroider/core": "^3.3.0",
+ "@embroider/core": "^3.4.0",

I suspect this regression is due to #1627

Below are the timings of rebuilds in both versions

@embroider/core@3.4.0 (bad)

Build successful (51382ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)    | Total (avg)
-----------------------------------+---------
@embroider/webpack (2)             | 47871ms (23935 ms)


Build successful (45543ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)    | Total (avg)
-----------------------------------+---------
@embroider/webpack (2)             | 42440ms (21220 ms)

@embroider/core@3.3.0 (good)

Build successful (11508ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)    | Total (avg)
-----------------------------------+---------
@embroider/webpack (2)             | 8659ms (4329 ms)
Funnel (1938)                      | 1237ms (0 ms)
@embroider/compat/app (1)          | 1047ms


Build successful (10568ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)    | Total (avg)
-----------------------------------+---------
@embroider/webpack (2)             | 7509ms (3754 ms)
Funnel (1938)                      | 1424ms (0 ms)
@embroider/compat/app (1)          | 1059ms

[ef4]

Please compare the resolver debug logs. DEBUG=embroider:resolver.

Also, double check that when you run with DEBUG=embroider:debug, rebuilds should print reusing webpack config and not configuring webpack.

[achambers]

Please compare the resolver debug logs. DEBUG=embroider:resolver.

Also, double check that when you run with DEBUG=embroider:debug, rebuilds should print reusing webpack config and not configuring webpack.

Yep, will do that tomorrow.

[raycohen]

Are you also seeing an initial build time regression? I'm seeing a jump from ~8 minutes to ~11 minutes on my initial build with the latest versions, after updating from compat 3.2.2 -> 3.3.1 and core 3.3.0 -> 3.4.2. I also suspected #1627 might be related.

[achambers]

https://github.com/embroider-build/embroider/releases/tag/v3.3.1-compat looks to have fixed this regression (see measurements below). I'm going to close this issue for now.

/cc @mansona

Release (2023-11-11)

-  "@embroider/compat": "^3.3.1",
-  "@embroider/core": "^3.4.2",
+  "@embroider/compat": "3.3.0",
+  "@embroider/core": "3.4.0",

Build successful (48339ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 45482ms (22741 ms)


Build successful (49058ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 46685ms (23342 ms)

Build successful (46734ms) – Serving on http://localhost:4200/a/


Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 44364ms (22182 ms)

Release (2023-11-15)

-  "@embroider/compat": "3.3.0",
-  "@embroider/core": "3.4.0",
+  "@embroider/compat": "3.3.1",
+  "@embroider/core": "3.4.1",

Build successful (9513ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 6650ms (3325 ms)
Funnel (1938)                                                            | 1139ms (0 ms)
@embroider/compat/app (1)                                                | 1000ms


Build successful (8752ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 6376ms (3188 ms)
Funnel (1938)                                                            | 917ms (0 ms)
@embroider/compat/app (1)                                                | 859ms


Build successful (8697ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 6282ms (3141 ms)
Funnel (1938)                                                            | 935ms (0 ms)
@embroider/compat/app (1)                                                | 891ms

Release (2023-11-16)

-  "@embroider/core": "3.4.1",
+  "@embroider/core": "3.4.2",

Build successful (11909ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 9156ms (4578 ms)
Funnel (1938)                                                            | 1061ms (0 ms)
@embroider/compat/app (1)                                                | 964ms


Build successful (9538ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 7018ms (3509 ms)
Funnel (1938)                                                            | 985ms (0 ms)
@embroider/compat/app (1)                                                | 920ms

Build successful (9396ms) – Serving on http://localhost:4200/a/

Slowest Nodes (totalTime >= 5%)                                          | Total (avg)
-------------------------------------------------------------------------+-------------------
@embroider/webpack (2)                                                   | 6921ms (3460 ms)
Funnel (1938)                                                            | 1012ms (0 ms)
@embroider/compat/app (1)                                                | 872ms