-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip fixed #30
Tooltip fixed #30
Conversation
- Use MaterialUI great theming system (makeStyle/useStyle) instead of external (s)CCS - Use more React composition - Fix indentation to 2 spaces - Fix space changes: they might not be ok, but your issue/PR is not about changing spaces - Move all CustomTooltip logic to a separate JSX file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just created a PR against your branch at SahanAmarsha#1
- Fix spaces and indentation back to original. If you want to fix it, open a PR only for that, else, it's impossible to follow what really changed. Also, JS indent standard is 2 spaces.
- Move Tooltip logic to a separate JSX file.
- Use UL/LI instead of TABLE. Table is only for data visualization, not for decoration (that was the very old Internet).
- Use MaterialUI theming system instead of an external CSS (not really a SCSS).
- Use more React Component composition
- Use
payload.map
instead of repeating.
You can apply it (even with squash to reduce the amount of commits and changes), and then I'll re-review it here.
Note: Using MaterialUI theming allows to change the theme easily. Currently (waiting for #5), it can be done setting the This is how it looks with the PR I've sent to your fork with This is how it looks with the PR I've sent to your fork with |
PR Review:
Learned a lot from this. Thanks! |
I don't think you should apologize for the mistakes, especially if you learned (from them and/or other stuff)! I am learning a lot with this project, too, both programming and as maintainer in a project with collaborators. This probably is a little bit confusing for newcomers to this project. I apologize for that ;) |
Sorry for taking so much time to make a pr, have been busy lately.
Issue: #10
(+)Chart.js
(+)Tooltip.scss