Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve implementation of linked plot bounds and cursors #2409

Closed
s-nie opened this issue Dec 8, 2022 · 0 comments · Fixed by #2410
Closed

Improve implementation of linked plot bounds and cursors #2409

s-nie opened this issue Dec 8, 2022 · 0 comments · Fixed by #2410
Labels
feature New feature or request

Comments

@s-nie
Copy link
Contributor

s-nie commented Dec 8, 2022

The linked bounds I originally introduced and the cursor groups that have since been implemented in a similar fashion have some drawbacks. Users have to create and store them between frames, which goes against egui's approach to store data between frames in its own memory. The stored Rc in these groups also puts some avoidable limitations on user code, e.g. parallelism.
I've also noticed a regression in the plot bound handling. Changing the plot bounds manually when linked axes are active makes the plot non-interactive.

I have a PR ready to addresses both of those issues.

@s-nie s-nie added the feature New feature or request label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant