Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthService should be tunable per mapping #1083

Closed
n1koo opened this issue Jan 6, 2019 · 1 comment
Closed

AuthService should be tunable per mapping #1083

n1koo opened this issue Jan 6, 2019 · 1 comment

Comments

@n1koo
Copy link
Contributor

n1koo commented Jan 6, 2019

Please describe your use case / problem.
We would benefit from AuthService being tunable per mapping as many folks will have both authenticated and unauthenticated endpoints behind the same gateway.

The typical example is that you have an API that both authenticated and unauthenticated endpoints.

Describe the solution you'd like
Per mapping boolean, eg.

---
apiVersion: ambassador/v0
kind: Mapping
name: cqrs_get_mapping
prefix: /cqrs/
method: GET
service: getcqrs
*auth_enabled: false*

Describe alternatives you've considered
Alternative and the solution i've heard others doing right now is keeping explicit whitelists in the authservice.

This has multiple downsides

  • Multiple places for endpoint configuration
  • AuthService on critical path for things that don't require it
  • Performance hit of extra hop

Theres also a big downside of returning custom 404's for dynamic stuff if you use whitelists that have to match exactly.

@kflynn
Copy link
Member

kflynn commented Jan 7, 2019

Closing as a dup of #174. Note that Envoy does support this now...

@kflynn kflynn closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants