Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: ConsulResolver environment variable expansion doesn't work without legacy mode #3317

Closed
woz5999 opened this issue Mar 30, 2021 · 2 comments
Closed

Regression: ConsulResolver environment variable expansion doesn't work without legacy mode #3317

woz5999 opened this issue Mar 30, 2021 · 2 comments
Assignees
@kflynn
Labels
t:bug Something isn't working w:5 Targeted for fifth week of development cycle
Milestone
2021 Cycle 3

Comments

@woz5999
Copy link

woz5999 commented Mar 30, 2021

Describe the bug
Per https://www.getambassador.io/docs/edge-stack/latest/topics/running/resolvers/ environment variable expansion is supported in the resolver address. However, as of 1.12.1, this doesn't work unless AMBASSADOR_LEGACY_MODE is also set.

time="2021-03-29 23:20:11" level=info msg="[ERR] consul.watch: Watch (type: service) errored: Get \"http://$%7BHOST_IP%7D/v1/health/service/test-api?passing=1\": dial tcp: lookup ${HOST_IP}: no such host, retry in 5s" CMD=entrypoint PID=1 oops-i-did-not-pass-context-correctly=true

To Reproduce
Steps to reproduce the behavior:

  1. Create a ConsulResolver with an environment variable in the address field

Expected behavior
It should expand the HOST_IP variable when querying consul

Versions (please complete the following information):

  • Ambassador: 1.12.1
@kflynn kflynn changed the title Environment variable expansion in ConsulResolver address field requires legacy mode Regression: ConsulResolver environment variable expansion doesn't work without legacy mode Mar 31, 2021
@khussey khussey added the t:bug Something isn't working label Mar 31, 2021
@khussey khussey added this to the 2021 Cycle 3 milestone Mar 31, 2021
@khussey khussey added the w:4 Targeted for fourth week of development cycle label Apr 1, 2021
@woz5999
Copy link
Author

woz5999 commented Apr 13, 2021

@khussey @kflynn looks like i created a duplicate of #3182

@khussey khussey added w:5 Targeted for fifth week of development cycle and removed w:4 Targeted for fourth week of development cycle labels Apr 14, 2021
@kflynn kflynn closed this as completed Apr 15, 2021
@khussey
Copy link
Contributor

khussey commented Apr 15, 2021

The fix for this will be available in the upcoming 1.13 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kflynn kflynn

Labels
t:bug Something isn't working w:5 Targeted for fifth week of development cycle
Projects
None yet
Milestone
2021 Cycle 3
Development

No branches or pull requests
3 participants
@khussey @kflynn @woz5999