From 89f3b0f6d3166fbcd984fb55f2ee45876d275709 Mon Sep 17 00:00:00 2001 From: Sun Yimin Date: Wed, 5 Jul 2023 17:51:26 +0800 Subject: [PATCH] sm4: add some comments for asm code --- sm4/aesni_macros_amd64.s | 4 ++-- sm4/asm_amd64.s | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sm4/aesni_macros_amd64.s b/sm4/aesni_macros_amd64.s index 10cb9a82..e7679481 100644 --- a/sm4/aesni_macros_amd64.s +++ b/sm4/aesni_macros_amd64.s @@ -302,8 +302,8 @@ GLOBL fk_mask<>(SB), 8, $16 // - x: 256 bits register as sbox input/output data // - y: 256 bits temp register // - z: 256 bits temp register -// - xw: 128 bits temp register -// - yw: 128 bits temp register +// - xw: 128 bits temp register, x's related low 128 bits register! +// - yw: 128 bits temp register, y's related low 128 bits register! // - xNibbleMask: 128 bits register stored nibble mask, should be loaded earlier. // - yNibbleMask: 256 bits register stored nibble mask, should be loaded earlier. #define AVX2_SM4_TAO_L1(x, y, z, xw, yw, xNibbleMask, yNibbleMask) \ diff --git a/sm4/asm_amd64.s b/sm4/asm_amd64.s index 84d4f0c5..12839223 100644 --- a/sm4/asm_amd64.s +++ b/sm4/asm_amd64.s @@ -92,8 +92,8 @@ // t0 ^= tao_l1(t1^t2^t3^xk) // parameters: // - index: round key index immediate number -// - x: 256 bits temp register -// - y: 256 bits temp register +// - x: 256 bits temp register, MUST use XDWORD! +// - y: 256 bits temp register, MUST use YDWORD! // - t0: 256 bits register for data as result // - t1: 256 bits register for data // - t2: 256 bits register for data