Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

提议:smx509 包用 type alias 来减少与标准库的代码差异 #14

Closed
xuyang2 opened this issue Jan 20, 2022 · 1 comment
Closed

Comments

@xuyang2
Copy link
Contributor

xuyang2 commented Jan 20, 2022

如:

type PEMCipher = x509.PEMCipher

const (
	PEMCipherDES    = x509.PEMCipherDES
	PEMCipher3DES   = x509.PEMCipher3DES
	PEMCipherAES128 = x509.PEMCipherAES128
	PEMCipherAES192 = x509.PEMCipherAES192
	PEMCipherAES256 = x509.PEMCipherAES256
)

type PublicKeyAlgorithm = x509.PublicKeyAlgorithm
...

另外 Certificate 和 CertificateRequest 似乎可以改成:

type Certificate x509.Certificate
type CertificateRequest x509.CertificateRequest

来减少与标准库的代码差异。

如果可以这么做,我可以提交PR。

@emmansun
Copy link
Owner

当然可以,欢迎修改。

@xuyang2 xuyang2 closed this as completed Jan 20, 2022
@xuyang2 xuyang2 changed the title 提议:smx509 包用 type alias 来减少与标准库的代码差异? 提议:smx509 包用 type alias 来减少与标准库的代码差异 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants