You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can not reasonably use an instanceof comparison to confirm that a given object is of type MongoDB since we may be using a different version of MongoDB than what a caller might be using. In this scenario, the check would fail.
We patched the checks using a required field in the IDbProperties object is set in #112. This required field is not a known field in MongoDB instance, thus it is arguably sane to check it
in this manner.
An ideal/better solution would be to make MongoDB a devDependency making it so the logic uses the consumer's own MongoDB package. This ticket tracks putting in place a better solution if possible.
The text was updated successfully, but these errors were encountered:
We can not reasonably use an
instanceof
comparison to confirm that a given object is of type MongoDB since we may be using a different version of MongoDB than what a caller might be using. In this scenario, the check would fail.We patched the checks using a required field in the IDbProperties object is set in #112. This required field is not a known field in MongoDB instance, thus it is arguably sane to check it
in this manner.
An ideal/better solution would be to make MongoDB a devDependency making it so the logic uses the consumer's own MongoDB package. This ticket tracks putting in place a better solution if possible.
The text was updated successfully, but these errors were encountered: