Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvement: "Show Statistics" button should be more visible #36

Closed
glynhudson opened this issue Nov 13, 2018 · 5 comments · Fixed by #57
Closed

UI improvement: "Show Statistics" button should be more visible #36

glynhudson opened this issue Nov 13, 2018 · 5 comments · Fixed by #57
Assignees

Comments

@glynhudson
Copy link
Member

The "Show Statistics" tag needs to be more prominent.

  • Make text darker (black?)
  • Make tab action more prominent

Extension of #35

@emrysr
Copy link
Contributor

emrysr commented Nov 13, 2018

Might be better to add a tab navigation here to jump between the two views?
[mock up of 2 tab layout]
graph-issue-36-mockup

@TrystanLea
Copy link
Member

Would using black font colour be sufficient?

@glynhudson
Copy link
Member Author

We did look test with a black font, however it just looked like a table header rather than a clickable tab hyperlink. The tab suggestion by @emrysr would make this very clear.

@TrystanLea
Copy link
Member

Keen for the flat styling to be in keeping with rest of the site, any other bootstrap v2 options that might work @emrysr ?

@emrysr
Copy link
Contributor

emrysr commented Jan 16, 2019

discussed with @TrystanLea and @glynhudson.. simplest fix is to use the built in bootstrap 2.3 class names for buttons:
image

the classes btn and btn-default (and 5px margin) will make the button look like the above screenshot

pasted edits from inspector :

<div class="feed-options-show-options hide btn btn-default" style="display: none;">Show options</div>
<div class="feed-options-show-stats btn btn-default" style="display: block;">Show statistics</div>

php

add the above classes to the html in Modules/graph/group_view.php and Modules/graph/view.php

css

Modules/graph/graph.css css changes from:

.feed-options-show-stats {
    float: right;
    padding: 10px;
    width: 150px;
    text-align: center;
    border-left: 1px solid #eee;
}

to:

.feed-options-show-stats {
    float: right;
    margin: 5px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants