Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Despina Adamopoulou <16343312+despadam@users.noreply.github.com>
  • Loading branch information
edoardob90 and despadam committed Apr 2, 2024
1 parent a6b3064 commit 509312a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion functions.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,10 @@
"Write a Python function called `greet` that takes two parameters: `name` (a string) and `age` (an integer).\n",
"The function should return a greeting message in the following format: `\"Hello, <name>! You are <age> years old.\"`\n",
"\n",
"**Do not** forget to write a proper docstring and add the correct type hints to the parameters and the return value."
<div class="alert alert-block alert-warning">
<h4><b>Note</b></h4>
<strong>Do not</strong> forget to write a proper docstring and add the correct type hints to the parameters and the return value.
</div>
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion tutorial/tests/test_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def read_data(name: str, data_dir: str = "data") -> pathlib.Path:

def reference_greet(name: str, age: int) -> str:
"""Reference solution for the greet exercise"""
return f"Hello {name}, you are {age} years old."
return f"Hello {name}! You are {age} years old."


def test_greet(function_to_test) -> None:
Expand Down

0 comments on commit 509312a

Please sign in to comment.