Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the code #22

Open
Varbin opened this issue Dec 26, 2017 · 0 comments
Open

Questions about the code #22

Varbin opened this issue Dec 26, 2017 · 0 comments

Comments

@Varbin
Copy link

Varbin commented Dec 26, 2017

While reading the code i stumbled across some strange things in the code:

  • Why is Threading.Thread a parent of every class? No multithreading capabilities are ever used. I was able to safely remove this.
  • Why is every attribute of the ShellDetector "private"? As python doesn't really support the concept of public/private attributes I find this strange and as far I know this isn't common practise. Generally: Why does nearly any variable name in a method start with an underscore?
  • Why regex is used for matching? Wouldn't Python's in operator be more readable (it's faster, too! source) The same is for every other string operation - instead of regex, Python's string methods would fit better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant