-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug on "decline" action #9
Labels
bug
Something isn't working
Comments
Hey, thanks. I added the fix 54ae635, will publish a new version in the week. |
Nice thank you! By the way, can i ask you to make a little addition to the Notice component? :) Or would you prefer if I created a new Issue? |
Please make another issue ;) |
Ok |
This should now be fixed in version 1.1.0, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have an issue with the modal and the notice. When the user click on the decline btn, or decline all, apps required are set to false.
In the callback of my app i have this log : "User consent for app myapp: consent=false",
and in the cookie set by Orejime my app is also set to false.
But visually in the modal the orejime-AppItem-slider is on position activate.
We can reproduce this issue on the demo page : https://orejime.netlify.com/
Can you fix this please?
[Edit]
After investigation I found where the bug is located.
In ConsentManager inside the declineAll function you have to add an if statement before the call of updateConsent to check if the app is required or not and then update to false only if it isn't required.
this.config.apps.map((app) => { if (!app.required) { this.updateConsent(app.name, false); } });
[Edit 2]
For the button decline all in the modal this is the function toggle that needs to be changed in /components/apps.js like this :
const toggle = (apps, value) => { apps.map((app)=>{ if (!app.required) { manager.updateConsent(app.name, value); } }) }
Can you put this fix in the repo please? @Leimi
The text was updated successfully, but these errors were encountered: