Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support for bigint on the JSON parsing #1410

Closed
BinarSkugga opened this issue Sep 5, 2023 · 2 comments
Closed

[Feature] Support for bigint on the JSON parsing #1410

BinarSkugga opened this issue Sep 5, 2023 · 2 comments
Assignees
@ysfscream
Labels
CLI MQTTX CLI desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature web MQTTX Web
Milestone
v1.9.7

Comments

@BinarSkugga
Copy link

Motivation

Support for 64bit numbers. Because JS uses a 52bit mantissa for all numbers, ids are truncated.

Detailed design

I know there is a couple of library in JS that do this:
https://www.npmjs.com/package/json-bigint (https://www.npmjs.com/package/@types/json-bigint)
https://www.npmjs.com/package/json-bigint-patch

Alternatives

Currently using the plaintext view.

More detail (optional)

With parsing:
image

Without:
image
@BinarSkugga BinarSkugga added the feature This pr is a feature label Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Backlog in MQTTX Sep 5, 2023
@ysfscream ysfscream self-assigned this Sep 6, 2023
@ysfscream ysfscream added enhancement New feature or request CLI MQTTX CLI web MQTTX Web desktop MQTTX Desktop labels Sep 6, 2023
@ysfscream ysfscream modified the milestones: v1.9.6, v1.9.7 Sep 6, 2023
@ysfscream
Copy link
Member

@BinarSkugga Thank you for the detailed information and suggestions! I noticed that this issue seems related to #740

We will address this in upcoming versions. Thanks again for your contribution and patience!

@ysfscream ysfscream moved this from Backlog to TO DO in MQTTX Sep 6, 2023
@ysfscream ysfscream moved this from TO DO to Backlog in MQTTX Sep 12, 2023
@ysfscream ysfscream moved this from Backlog to TO DO in MQTTX Sep 21, 2023
@ysfscream ysfscream mentioned this issue Oct 20, 2023
Closed
@ysfscream ysfscream mentioned this issue Nov 28, 2023
Closed
@ni00 ni00 mentioned this issue Nov 30, 2023
Merged
2 tasks
@ysfscream ysfscream moved this from TO DO to In Progress in MQTTX Dec 7, 2023
@ysfscream ysfscream modified the milestones: v1.9.7, v1.9.8 Dec 8, 2023
@ysfscream
Copy link
Member

This issue has been fixed in the MQTTX v1.9.7 release. Thank you for your feedback.

@github-project-automation github-project-automation bot moved this from In Progress to Done in MQTTX Dec 8, 2023
@ysfscream ysfscream modified the milestones: v1.9.8, v1.9.7 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysfscream ysfscream

Labels
CLI MQTTX CLI desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature web MQTTX Web
Projects
MQTTX
Status: Done
Milestone
v1.9.7
Development

No branches or pull requests
2 participants
@BinarSkugga @ysfscream