From 8e5369d3783d684e6ac1d754d5e5ffa686ec7272 Mon Sep 17 00:00:00 2001 From: Jiye Kim Date: Mon, 18 Nov 2024 15:51:34 +0900 Subject: [PATCH 1/3] WRR-387: Updated documentation for Panels arranger Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) --- internal/Panels/Arrangers.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/Panels/Arrangers.js b/internal/Panels/Arrangers.js index 315a3333e3..6c5c3e3b66 100644 --- a/internal/Panels/Arrangers.js +++ b/internal/Panels/Arrangers.js @@ -129,6 +129,9 @@ const deferArrange = (config, keyframes, options) => { /** * Arranger that slides panels in from the right and out to the left. * + * This arranger is visually same as {@link ui/ViewManager.SlideLeftArranger} when transition but uses transform percentages instead of pixel values. + * Because BasicArranger is an optimized version of {@link ui/ViewManager.SlideLeftArranger}, {@link ui/ViewManager.SlideLeftArranger} can be written in documentation instead of BasicArranger in unavoidable case. + * * @type {Arranger} * @private */ From 203974b0e6894d9775e59f87d524924d56e54a19 Mon Sep 17 00:00:00 2001 From: Jiye Kim Date: Mon, 16 Dec 2024 16:05:57 +0900 Subject: [PATCH 2/3] Updated documentation Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) --- internal/Panels/Arrangers.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/Panels/Arrangers.js b/internal/Panels/Arrangers.js index 6c5c3e3b66..67a7b58519 100644 --- a/internal/Panels/Arrangers.js +++ b/internal/Panels/Arrangers.js @@ -129,8 +129,8 @@ const deferArrange = (config, keyframes, options) => { /** * Arranger that slides panels in from the right and out to the left. * - * This arranger is visually same as {@link ui/ViewManager.SlideLeftArranger} when transition but uses transform percentages instead of pixel values. - * Because BasicArranger is an optimized version of {@link ui/ViewManager.SlideLeftArranger}, {@link ui/ViewManager.SlideLeftArranger} can be written in documentation instead of BasicArranger in unavoidable case. + * This arranger is visually same as {@link ui/ViewManager.SlideLeftArranger} when transition but prevents skipping transition animations under system load. + * Because BasicArranger is an improved version of {@link ui/ViewManager.SlideLeftArranger}, {@link ui/ViewManager.SlideLeftArranger} can be written in documentation instead of BasicArranger in unavoidable case. * * @type {Arranger} * @private From c3df2c80bbdbc0afd1b7440200e062b77853fa64 Mon Sep 17 00:00:00 2001 From: Jiye Kim Date: Thu, 19 Dec 2024 13:46:39 +0900 Subject: [PATCH 3/3] review changes Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) --- internal/Panels/Arrangers.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/Panels/Arrangers.js b/internal/Panels/Arrangers.js index 67a7b58519..1284c1c15e 100644 --- a/internal/Panels/Arrangers.js +++ b/internal/Panels/Arrangers.js @@ -129,8 +129,10 @@ const deferArrange = (config, keyframes, options) => { /** * Arranger that slides panels in from the right and out to the left. * - * This arranger is visually same as {@link ui/ViewManager.SlideLeftArranger} when transition but prevents skipping transition animations under system load. - * Because BasicArranger is an improved version of {@link ui/ViewManager.SlideLeftArranger}, {@link ui/ViewManager.SlideLeftArranger} can be written in documentation instead of BasicArranger in unavoidable case. + * This arranger is visually the same as {@link ui/ViewManager.SlideLeftArranger} when transition + * but prevents skipping transition animations under system load. + * Because BasicArranger is an improved version of {@link ui/ViewManager.SlideLeftArranger}, + * {@link ui/ViewManager.SlideLeftArranger} can be written in documentation instead of BasicArranger in unavoidable case. * * @type {Arranger} * @private