From 95568b0aa7e5231f6a23a022e109f08475321872 Mon Sep 17 00:00:00 2001 From: Daniel Stoian Date: Tue, 3 Dec 2024 12:26:47 +0200 Subject: [PATCH 1/4] Fixed JSDoc problems --- DatePicker/DatePicker.js | 2 +- TimePicker/TimePicker.js | 2 +- TooltipDecorator/util.js | 5 ----- internal/validators/validators.js | 2 -- 4 files changed, 2 insertions(+), 9 deletions(-) diff --git a/DatePicker/DatePicker.js b/DatePicker/DatePicker.js index cfb30ff688..4fd67a1f8b 100644 --- a/DatePicker/DatePicker.js +++ b/DatePicker/DatePicker.js @@ -161,7 +161,7 @@ const DatePicker = Pure( * @function * @memberof sandstone/DatePicker * @param {Date} date `Date` to convert - * @returns {String?} Converted date or `null` if `date` is invalid + * @returns {String|Null} Converted date or `null` if `date` is invalid */ const dateToLocaleString = (date) => { if (!date) { diff --git a/TimePicker/TimePicker.js b/TimePicker/TimePicker.js index d81ce248dc..8cb8a9746d 100644 --- a/TimePicker/TimePicker.js +++ b/TimePicker/TimePicker.js @@ -247,7 +247,7 @@ const TimePicker = Pure( * @function * @memberof sandstone/TimePicker * @param {Date} time `Date` to convert - * @returns {String?} Converted date or `null` if `date` is invalid + * @returns {String|Null} Converted date or `null` if `date` is invalid */ const timeToLocaleString = (time) => { if (!time) { diff --git a/TooltipDecorator/util.js b/TooltipDecorator/util.js index b24b56ccbc..61be4bbc25 100644 --- a/TooltipDecorator/util.js +++ b/TooltipDecorator/util.js @@ -156,13 +156,8 @@ const calcOverflow = function (tooltipNode, clientNode, tooltipDirection, edgeKe * * @method * @memberof sandstone/TooltipDecorator - * @param {Object} tooltipNode The `getBoundingClientRect` values for tooltip node * @param {Object} clientNode The `getBoundingClientRect` values for client node - * @param {String} arrowAnchor Anchor position from `adjustAnchor` * @param {String} tooltipDirection Direction of tooltip - * @param {Number} tooltipHeight Tooltip height - * @param {Object} overflow Tooltip's calculated overflow from `calcOverflow` - * @param {Boolean} rtl RTL mode * @returns {Object} Tooltip top and left position * @private */ diff --git a/internal/validators/validators.js b/internal/validators/validators.js index 9fb40b60e1..e29a2b12f1 100644 --- a/internal/validators/validators.js +++ b/internal/validators/validators.js @@ -10,8 +10,6 @@ * * @function * @param {String} msg Event name - * @param {Function} fn Event handler - * @param {Node} [target=`document`] Event listener target * * @returns {undefined} * @memberof sandstone/internal/validators From 527e9933ece64229a52bec73723ed7434d429631 Mon Sep 17 00:00:00 2001 From: Daniel Stoian Date: Tue, 3 Dec 2024 13:24:01 +0200 Subject: [PATCH 2/4] dummy commit --- ActionGuide/ActionGuide.js | 1 + 1 file changed, 1 insertion(+) diff --git a/ActionGuide/ActionGuide.js b/ActionGuide/ActionGuide.js index c5d0c0f171..20ad5c50b4 100644 --- a/ActionGuide/ActionGuide.js +++ b/ActionGuide/ActionGuide.js @@ -10,6 +10,7 @@ * @exports ActionGuideDecorator */ + import kind from '@enact/core/kind'; import Pure from '@enact/ui/internal/Pure'; import PropTypes from 'prop-types'; From 5fea31677f77f722dcbff69ff5742346e0eb54f1 Mon Sep 17 00:00:00 2001 From: Daniel Stoian Date: Tue, 3 Dec 2024 13:24:20 +0200 Subject: [PATCH 3/4] revert dummy commit --- ActionGuide/ActionGuide.js | 1 - 1 file changed, 1 deletion(-) diff --git a/ActionGuide/ActionGuide.js b/ActionGuide/ActionGuide.js index 20ad5c50b4..c5d0c0f171 100644 --- a/ActionGuide/ActionGuide.js +++ b/ActionGuide/ActionGuide.js @@ -10,7 +10,6 @@ * @exports ActionGuideDecorator */ - import kind from '@enact/core/kind'; import Pure from '@enact/ui/internal/Pure'; import PropTypes from 'prop-types'; From f31eeaa59aeec7a359574e4300c87651581c61ad Mon Sep 17 00:00:00 2001 From: Daniel Stoian Date: Tue, 17 Dec 2024 10:44:20 +0200 Subject: [PATCH 4/4] code review fixes --- DatePicker/DatePicker.js | 2 +- TimePicker/TimePicker.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DatePicker/DatePicker.js b/DatePicker/DatePicker.js index 4fd67a1f8b..a036855682 100644 --- a/DatePicker/DatePicker.js +++ b/DatePicker/DatePicker.js @@ -161,7 +161,7 @@ const DatePicker = Pure( * @function * @memberof sandstone/DatePicker * @param {Date} date `Date` to convert - * @returns {String|Null} Converted date or `null` if `date` is invalid + * @returns {String|null} Converted date or `null` if `date` is invalid */ const dateToLocaleString = (date) => { if (!date) { diff --git a/TimePicker/TimePicker.js b/TimePicker/TimePicker.js index 8cb8a9746d..dcfdb83f9d 100644 --- a/TimePicker/TimePicker.js +++ b/TimePicker/TimePicker.js @@ -247,7 +247,7 @@ const TimePicker = Pure( * @function * @memberof sandstone/TimePicker * @param {Date} time `Date` to convert - * @returns {String|Null} Converted date or `null` if `date` is invalid + * @returns {String|null} Converted date or `null` if `date` is invalid */ const timeToLocaleString = (time) => { if (!time) {