Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework crate structure #139

Closed
rvolosatovs opened this issue Dec 6, 2022 · 0 comments · Fixed by #140
Closed

Rework crate structure #139

rvolosatovs opened this issue Dec 6, 2022 · 0 comments · Fixed by #140
Assignees
@rjzak

Comments

@rvolosatovs
Copy link
Member

Currently, there are multiple crates in this repository, which are difficult to maintain. #107 added a 4th crate, validation_common.

Instead, I think we should have just two crates here:

  • one containing the Steward binary and the server implementation
  • one containing the attestation-specific functionality

As the quickest way forward, how about we consolidate all crates/* contents into a single attestation crate with following modules:

  • attestation::sgx
  • attestation::snp

Common functionality can reside in top-level attestation
@rjzak rjzak mentioned this issue Dec 6, 2022
Merged
@rjzak rjzak self-assigned this Dec 6, 2022
@rjzak rjzak closed this as completed in #140 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjzak rjzak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: consolidate crates rjzak/steward
2 participants
@rjzak @rvolosatovs