Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python-multipart dependency #2390

Open
Kludex opened this issue Dec 29, 2023 · 5 comments
Open

Drop python-multipart dependency #2390

Kludex opened this issue Dec 29, 2023 · 5 comments
Labels
feature New feature or request
Milestone

Comments

@Kludex
Copy link
Sponsor Member

Kludex commented Dec 29, 2023

We should have the multipart parsing on Starlette itself.

Important

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@Kludex Kludex added the feature New feature or request label Dec 29, 2023
@Kludex Kludex modified the milestones: Version 1.0, Version 1.x Feb 17, 2024
@nanda-mik
Copy link

@Kludex, I'd like to take on this task, please assign me. I've understood the parser classes and written test cases for them. I've also started implementing the parser functionality to phase out the dependency on python-multipart. I will try to complete this in some days and will submit a PR then.

Could you provide any specific things or best practices I should follow during the implementation? Additionally, would it be preferable to push the entire change at once or make smaller, incremental PRs?

Thanks!

@rafalkrupinski
Copy link

what's wrong with python-multipart?

@Kludex
Copy link
Sponsor Member Author

Kludex commented Aug 11, 2024

Nothing.

@adriangb
Copy link
Member

I think the point is that even if nothing is wrong with it Starlette should still absorb that functionality since it's quite core to what Starlette does.

@rafalkrupinski
Copy link

I'd rather extract functions like this from existing projects, for greater modularization and to facilitate re-use, but you be you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants