Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Scope missing fields #578

Closed
nwalsh1995 opened this issue Feb 20, 2020 · 1 comment · Fixed by #597
Closed

HTTP Scope missing fields #578

nwalsh1995 opened this issue Feb 20, 2020 · 1 comment · Fixed by #597

Comments

@nwalsh1995
Copy link

https://asgi.readthedocs.io/en/latest/specs/www.html#connection-scope

The connection scope contains:
...
asgi["version"] (Unicode string) – Version of the ASGI spec.
asgi["spec_version"] (Unicode string) – Version of the ASGI HTTP spec this server understands; one of "2.0" or "2.1". Optional; if missing assume 2.0.

I sent a request through uvicorn and noticed these fields are missing. Additionally searching the code for "spec_version" does not return any hits so I think these fields are not being handled. Potentially these were added in a later ASGI version that is not supported or I may be misunderstanding what the ASGI docs mean.

@tomchristie
Copy link
Member

Yup I think they were added later on. Would totally accept PRs adding these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants