Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion Between Minimum PHP version (7.2 or 7.3) #61

Open
rogojagad opened this issue Jan 20, 2021 · 0 comments
Open

Confusion Between Minimum PHP version (7.2 or 7.3) #61

rogojagad opened this issue Jan 20, 2021 · 0 comments

Comments

@rogojagad
Copy link

I notice there are differences for the minimum PHP version on the package's readme.md and the composer.json

On the readme.md, it is said that the minimum PHP version is PHP ^7.3

Screenshot from 2021-01-20 11-40-43

But the rule on composer.json state that the minimum PHP version is ^7.2

"require": { "php": "^7.2", "ext-json": "*", "guzzlehttp/guzzle": "^6.3", "symfony/polyfill-apcu": "^1.6" },

I think the mistake on the readme.md since the composer.json is the one that is consumed by the composer. I will gladly open a Pull Request if this issue is confirmed.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant